Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: movePlayerTo() avatarTarget param #1065

Closed
wants to merge 5 commits into from

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Feb 10, 2025

Copy link

cloudflare-workers-and-pages bot commented Feb 10, 2025

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 829f027
Status: ✅  Deploy successful!
Preview URL: https://3e4369c7.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-move-player-character-p.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/move-player-character-param/dcl-sdk-7.7.5-13308814967.commit-e2add6a.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/move-player-character-param/dcl-sdk-commands-7.7.5-13308814967.commit-e2add6a.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/move-player-character-param/@dcl/inspector/dcl-inspector-7.7.5-13308814967.commit-e2add6a.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/move-player-character-param-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/move-player-character-param

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.65%. Comparing base (86c87c6) to head (0d9baa5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
+ Coverage   62.04%   71.65%   +9.61%     
==========================================
  Files         599      159     -440     
  Lines       19986     5314   -14672     
  Branches     2413      962    -1451     
==========================================
- Hits        12401     3808    -8593     
+ Misses       7163     1373    -5790     
+ Partials      422      133     -289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pravusjif pravusjif changed the base branch from main to experimental February 13, 2025 13:23
@pravusjif pravusjif changed the base branch from experimental to main February 13, 2025 13:23
@pravusjif
Copy link
Member Author

Closing to re-create starting from the experimental branch

@pravusjif pravusjif closed this Feb 14, 2025
@pravusjif pravusjif deleted the feat/move-player-character-param branch February 14, 2025 13:35
@pravusjif pravusjif changed the title feat: movePlayerTo new character rotation feat: movePlayerTo() avatarTarget param Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant