Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sdk movePlayerTo() improvements #3328

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Feb 10, 2025

WHY

Related PRs:

WHAT

  • movePlayerTo() has to have effect even when not changing the player's current position (e.g. newRelativePosition: Transform.get(engine.PlayerEntity).position)
  • Add new avatarTarget parameter to movePlayerTo() as specified in this ADR and issue Add avatar rotation to MovePlayerTo() creator-hub#214
  • Add camera mode param ???

TEST

...

@pravusjif pravusjif self-assigned this Feb 10, 2025
@pravusjif pravusjif changed the title feat: sdk movePlayerTo new character rotation feat: sdk movePlayerTo() improvements Feb 14, 2025
@pravusjif pravusjif added the force-build Used to trigger a build on draft PR label Feb 14, 2025
@pravusjif pravusjif added force-build Used to trigger a build on draft PR and removed force-build Used to trigger a build on draft PR labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature feature a new feature force-build Used to trigger a build on draft PR sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants