Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Build and doco updates for Go 1.19. #2981

Merged
merged 5 commits into from
Aug 7, 2022

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Aug 2, 2022

This consists of several commit to update the CI and documentation for Go 1.19. It also takes the opportunity to bump to the latest linter and action versions.

In particular:

  • docs: Update README.md to required Go 1.18/1.19.
  • build: Test against Go 1.19 and remove Go 1.17 accordingly.
  • build: Update golangci-lint to v1.48.0.
  • build: Update to latest action versions.
    • actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a #v3.2.1
    • actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b #v3.0.2

@davecgh davecgh added this to the 1.8.0 milestone Aug 2, 2022
@davecgh davecgh added test coverage Discussion and pull requests for improving test coverage. documentation Issues and/or pull requests related to documentation. labels Aug 2, 2022
Copy link
Member Author

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to wait until the linter is updated to work with Go 1.19.

@chappjc
Copy link
Member

chappjc commented Aug 2, 2022

I'm subscribed to golangci/golangci-lint#3037 to be alerted when golangci-lint is ready.

@davecgh davecgh marked this pull request as draft August 3, 2022 00:03
@davecgh davecgh marked this pull request as ready for review August 4, 2022 23:21
@davecgh davecgh merged commit 1ac88ba into decred:master Aug 7, 2022
@davecgh davecgh deleted the multi_go_1_19 branch August 7, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues and/or pull requests related to documentation. test coverage Discussion and pull requests for improving test coverage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants