-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go1.19 support #3037
Merged
Merged
go1.19 support #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
feat/go119
branch
2 times, most recently
from
August 1, 2022 14:04
f4fc114
to
36f9467
Compare
4 tasks
ncw
added a commit
to rclone/rclone
that referenced
this pull request
Aug 3, 2022
maxatome
added a commit
to maxatome/go-testdeep
that referenced
this pull request
Aug 3, 2022
until golangci/golangci-lint/pull/3037 is resolved. Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
maxatome
added a commit
to maxatome/go-testdeep
that referenced
this pull request
Aug 3, 2022
until golangci/golangci-lint/pull/3037 is resolved. Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
ncw
added a commit
to rclone/rclone
that referenced
this pull request
Aug 3, 2022
ncw
added a commit
to rclone/rclone
that referenced
this pull request
Aug 3, 2022
ncw
added a commit
to rclone/rclone
that referenced
this pull request
Aug 3, 2022
lopezator
reviewed
Aug 3, 2022
lafriks
approved these changes
Aug 3, 2022
> go version
go version go1.19 linux/amd64
> golangci-lint
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x4b4 or should this be reported into https://github.com/go-critic/go-critic ? |
Looks duplicate to #3053 |
We will create a release with go1.19 support at 6:00 pm (UTC) |
I still can see the panic: > brew info golangci-lint
golangci-lint: stable 1.48.0 (bottled), HEAD
Fast linters runner for Go
https://golangci-lint.run/
/home/linuxbrew/.linuxbrew/Cellar/golangci-lint/1.48.0 (9 files, 29.5MB) *
Poured from bottle on 2022-08-05 at 13:03:48
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/golangci-lint.rb
License: GPL-3.0-only
==> Dependencies
Required: go ✔
==> Options
--HEAD
Install HEAD version
==> Caveats
Bash completion has been installed to:
/home/linuxbrew/.linuxbrew/etc/bash_completion.d
==> Analytics
install: 16,649 (30 days), 39,753 (90 days), 109,201 (365 days)
install-on-request: 16,638 (30 days), 39,726 (90 days), 109,094 (365 days)
build-error: 9 (30 days)
> golangci-lint
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x4b4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to evaluate and prepare golangci-lint to go1.19.
This PR will evolve during the beta and rc phases of go1.19.
Fixes #2922