Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go1.19 support #3037

Merged
merged 7 commits into from
Aug 3, 2022
Merged

go1.19 support #3037

merged 7 commits into from
Aug 3, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 1, 2022

This PR is to evaluate and prepare golangci-lint to go1.19.

This PR will evolve during the beta and rc phases of go1.19.

Fixes #2922

@ldez ldez added the enhancement New feature or improvement label Aug 1, 2022
@ldez ldez force-pushed the feat/go119 branch 2 times, most recently from f4fc114 to 36f9467 Compare August 1, 2022 14:04
@ldez ldez marked this pull request as ready for review August 3, 2022 08:30
@ldez ldez mentioned this pull request Aug 3, 2022
4 tasks
ncw added a commit to rclone/rclone that referenced this pull request Aug 3, 2022
maxatome added a commit to maxatome/go-testdeep that referenced this pull request Aug 3, 2022
until golangci/golangci-lint/pull/3037 is resolved.

Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
maxatome added a commit to maxatome/go-testdeep that referenced this pull request Aug 3, 2022
until golangci/golangci-lint/pull/3037 is resolved.

Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
ncw added a commit to rclone/rclone that referenced this pull request Aug 3, 2022
ncw added a commit to rclone/rclone that referenced this pull request Aug 3, 2022
ncw added a commit to rclone/rclone that referenced this pull request Aug 3, 2022
@ldez ldez merged commit 1557692 into golangci:master Aug 3, 2022
@ldez ldez deleted the feat/go119 branch August 3, 2022 18:53
@yermulnik
Copy link

> go version
go version go1.19 linux/amd64

> golangci-lint
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
        github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x4b4

or should this be reported into https://github.com/go-critic/go-critic ?

@Don-Vito
Copy link

Don-Vito commented Aug 4, 2022

Looks duplicate to #3053

@ldez
Copy link
Member Author

ldez commented Aug 4, 2022

We will create a release with go1.19 support at 6:00 pm (UTC)

@yermulnik
Copy link

Looks duplicate to #3053

#3053 cycles back to here =)

We will create a release with go1.19 support at 6:00 pm (UTC)

Thanks 👍🏻

@yermulnik
Copy link

I still can see the panic:

> brew info golangci-lint
golangci-lint: stable 1.48.0 (bottled), HEAD
Fast linters runner for Go
https://golangci-lint.run/
/home/linuxbrew/.linuxbrew/Cellar/golangci-lint/1.48.0 (9 files, 29.5MB) *
  Poured from bottle on 2022-08-05 at 13:03:48
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/golangci-lint.rb
License: GPL-3.0-only
==> Dependencies
Required: go ✔
==> Options
--HEAD
        Install HEAD version
==> Caveats
Bash completion has been installed to:
  /home/linuxbrew/.linuxbrew/etc/bash_completion.d
==> Analytics
install: 16,649 (30 days), 39,753 (90 days), 109,201 (365 days)
install-on-request: 16,638 (30 days), 39,726 (90 days), 109,094 (365 days)
build-error: 9 (30 days)

> golangci-lint
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
        github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x4b4

@ldez
Copy link
Member Author

ldez commented Aug 5, 2022

#2673 (comment)

@golangci golangci locked as off-topic and limited conversation to collaborators Aug 5, 2022
@ldez ldez added this to the v1.48 milestone Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-critic: checkers.init panic with go1.19beta1
5 participants