Use golang 1.19 #1021
Merged
Use golang 1.19 #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
commented
Aug 3, 2022
| - name: Check out code into the Go module directory | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Lint | ||
| uses: golangci/golangci-lint-action@v3 | ||
| with: | ||
| args: -v | ||
| version: v1.45 | ||
| version: v1.47 |
There was a problem hiding this comment.
golangci does not support go 1.19 just yet golangci/golangci-lint#3037
There was a problem hiding this comment.
I cannot get the linter to work. see as well golangci/golangci-lint#2374 (comment)
|
I am happy to merge this and book an issue to update golangci once it supports golang 1.19 |
frzifus
reviewed
Aug 3, 2022
what downgrade? |
This one? 9e6d86b |
|
There is no downgrade, I have reverted it back to the original version. |
pavolloffay
commented
Aug 11, 2022
| //Following Otel Doc: Configuring a receiver does not enable it. The receivers are enabled via pipelines within the service section. | ||
| //GetEnabledReceivers returns all enabled receivers as a true flag set. If it can't find any receiver, it will return a nil interface. | ||
| func GetEnabledReceivers(logger logr.Logger, config map[interface{}]interface{}) map[interface{}]bool { | ||
| // Following Otel Doc: Configuring a receiver does not enable it. The receivers are enabled via pipelines within the service section. |
There was a problem hiding this comment.
lint was complaining that there was no space
| @@ -17,7 +17,7 @@ package reconcile | |||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "io/ioutil" | |||
There was a problem hiding this comment.
io/ioutil is deprecated
|
PR is ready to be merged |
pavolloffay
force-pushed
the
use-go-1.19
branch
from
71ee75a
to
3c5699f
Compare
|
@pavolloffay, could you please rebase it? |
VineethReddy02
approved these changes
Aug 30, 2022
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
force-pushed
the
use-go-1.19
branch
from
7b3347a
to
6126c69
Compare
|
PR rebased. |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Signed-off-by: Pavol Loffay <p.loffay@gmail.com> Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay p.loffay@gmail.com