ticketpool chart data inline -> AJAX #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
force-pushed
the
ticketpool-chart-data
branch
from
9b6f40c to
c563486
Compare
chappjc
requested changes
Dec 6, 2018
buck54321
force-pushed
the
ticketpool-chart-data
branch
from
c563486 to
a3c0bc8
Compare
|
Got some more conflicts. The one in explorerroutes.go is just because StatusPage got that extra input, but the call is gone so not really a conflict. :) The other conflicts are from your other PRs I think. |
…cificity in charts.scss.
buck54321
force-pushed
the
ticketpool-chart-data
branch
from
a3c0bc8 to
40b902c
Compare
chappjc
approved these changes
Dec 7, 2018
|
Code looks good, and everything behaves as expected in testing. However, one thing I just noticed now is that it looks like the ticketpool controller's "wrapper" target is not used. If I'm just missing it, please let me know what it's for. |
|
Oh yeah. I was planning on getting rid of some jQuery in favor of stimulus, but I guess I never finished. I've done that now. I've also taken a queue from @gozart1 and switched to arrow functions where appropriate, though I left the more semantic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes inline data from the ticketpool page. Initial chart data is retrieved instead via AJAX.
There is a websocket call that retrieves the same data. I left the websocket source, though now that there is an API endpoint, there may be an argument against the duplication.