Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last of the inline JS removed #873

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Conversation

buck54321
Copy link
Member

  1. Inline DCRThings moved to index.js
  2. The stats page is a mystery to me (is there a link to it somewhere?), but it had some code for tooltips using a bootstrap jQuery plugin, which doesn't appear to be installed. I just removed the code. It does have a title that renders pretty nicely on dektop, though the page itself has some issues in firefox. I also removed some extraneous and duplicate id attributes I suspect of being copypasta.
  3. New stimulus controller for the ticket price windows page.

@buck54321 buck54321 mentioned this pull request Dec 10, 2018
9 tasks
@chappjc
Copy link
Member

chappjc commented Dec 10, 2018

Regarding the stats page, there are several pages that are not quite ready for primetime -- stats and nexthome are among them.

There's also /rejects (pos-invalidated blocks) and /side (side chains / orphaned blocks), which probably deserve links somewhere now. I didn't want to put them on the nav menu since it's getting crowded already. Suggestions are welcome from all on this.

…stics.tmpl. moved windows.tmpl inline js to stimulus.
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. All good LGTM. Stimulus FTW!

@chappjc chappjc merged commit e5d363f into decred:master Dec 10, 2018
@chappjc chappjc added this to the 4.0 milestone Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants