Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bower.json #69

Closed
wants to merge 1 commit into from
Closed

Added bower.json #69

wants to merge 1 commit into from

Conversation

marad
Copy link

@marad marad commented Jun 14, 2014

This will provide better integration with https://github.com/yatskevich/grunt-bower-task.
The most important here is "main" property which specifies the main file.
Without it grunt-bower-task will copy whole repository to build folder.

@ded
Copy link
Owner

ded commented Jun 17, 2014

hi there. you can use npm install scriptjs

@ded ded closed this Jun 17, 2014
@marad
Copy link
Author

marad commented Jun 17, 2014

I believe that this library is strictly client-side (working in browser) and you are suggesting using node package manager (server-side package manager) so it's not the tool for the job. On the other hand your library is available through bower which is client-side package manager and is more suitable for the job. Unfortunately it lacks proper configuration for bower and that's why I created that pull request. In addition it will enhance the integration with other tools like mentioned earlier grunt-bower-task (which I use while building the project).

Please reconsider adding bower.json file to your repository.

@ded
Copy link
Owner

ded commented Jun 17, 2014

for what it's worth, you can still install it with bowser install scriptjs already if you truly desire this since it is properly tagged and living on github.

on the topic of npm — it is a general package manager, not only for server-side libraries, but all things JavaScript, like this library. you can also use other package managers, like http://enderjs.com, which have no problem fetching packages from github or npm and can inspect the contents of a package via package.json instead of an additional bower file.

and on a final note, please don't take this as a personal offense. I've had dozens of other requests across my [https://github.com/ded?tab=repositories](other libraries) and have chosen to not "support" installation via bower as it ultimately becomes an extra step not worth maintaining when there are perfectly other good ways to include this package in a project.

thanks for understanding

@marad
Copy link
Author

marad commented Jun 18, 2014

Well I guess it's your decision to make :) I know that I can install this with bower and I did this, but I had to manually add "main" to .bower.json (which I guess is autogenerated) in the downloaded folder to make grunt-bower-task properly handle that library.

The lack of bower.json with "main" section is a major problem here because it does not work great with aforementioned grunt plugin. And lack of this unfortunately renders this library unusable for me because this would require changing build whole projects build sctructure/process and that simply is not worth it.

I wonder if you can add bower.json file only with "main" section? This wouldn't require any maintenance at all but I'm not sure if bower would be happy with that.

@ryanve
Copy link

ryanve commented Jun 19, 2014

@marad Maybe you can use bower install marad/script.js and solve it there.

@lifeiscontent
Copy link

@ded what about the ease that rails-assets.org adds via bower packages? https://rails-assets.org/#/components/script.js

@joaovieira
Copy link

joaovieira commented Mar 28, 2017

As @marad said, this is not properly configured for Bower. If you want to have it registered in Bower, then it should have a bower.json manifest. That's how loaders (webpack, rollup, etc.) and/or grunt/gulp plugins resolve the files for bower components. Obviously, people can (and should) use npm, but the Bower setup is still broken. To be honest, it should've had a bower.json at the time of registration (https://bower.io/docs/creating-packages/#register) but somehow you've made it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants