Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncChain can go into an infinite loop #1980

Closed
2 tasks done
jeffallen opened this issue Jun 25, 2019 · 1 comment · Fixed by #1984
Closed
2 tasks done

syncChain can go into an infinite loop #1980

jeffallen opened this issue Jun 25, 2019 · 1 comment · Fixed by #1984
Assignees
@ineiti @Gilthoniel

Comments

@jeffallen
Copy link
Contributor

jeffallen commented Jun 25, 2019 •
edited by ineiti
Loading

Ineiti writes: This happened when I deleted the .db on gasser.blue and then tried to get the chain loaded from the roster again.

Proposed changes:

  • verify why it passes the test, and get the test to fail, then fix it
  • work on a better way to have a node update / download a given chain
@ineiti ineiti self-assigned this Jun 27, 2019
@ineiti ineiti mentioned this issue Jun 28, 2019
Merged
@ineiti
Copy link
Member

ineiti commented Jun 28, 2019

Waiting for dedis/onet#559

ineiti added a commit to c4dt/cothority that referenced this issue Jul 9, 2019
@ineiti
Testing and simplifying catchup
579e659 
The previous tests only unit-tested the catchup and downloadDB methods. This test
runs it in a more production-like environment with transactions being processed
as the node catches up. A couple of problems got fixed:

* it uses the new SendProtobufParallel to simplify sending of messages
* downloadDB now stores the new blocks
* byzcoin.verifySkipblock checks if it needs to catchup

Depends on dedis/onet#559
Closes dedis#1980
ineiti added a commit to c4dt/cothority that referenced this issue Jul 9, 2019
@ineiti
Testing and simplifying catchup
ae285a3 
The previous tests only unit-tested the catchup and downloadDB methods. This test
runs it in a more production-like environment with transactions being processed
as the node catches up. A couple of problems got fixed:

* it uses the new SendProtobufParallel to simplify sending of messages
* downloadDB now stores the new blocks
* byzcoin.verifySkipblock checks if it needs to catchup

Depends on dedis/onet#559
Closes dedis#1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ineiti ineiti

@Gilthoniel Gilthoniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Testing and simplifying catchup c4dt/cothority
3 participants
@jeffallen @ineiti @Gilthoniel