Testing and simplifying catchup #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
sync_chain_1980
branch
4 times, most recently
from
aa07ddc to
81cc105
Compare
ineiti
force-pushed
the
sync_chain_1980
branch
2 times, most recently
from
bebe6cd to
579e659
Compare
The previous tests only unit-tested the catchup and downloadDB methods. This test runs it in a more production-like environment with transactions being processed as the node catches up. A couple of problems got fixed: * it uses the new SendProtobufParallel to simplify sending of messages * downloadDB now stores the new blocks * byzcoin.verifySkipblock checks if it needs to catchup Depends on dedis/onet#559 Closes dedis#1980
Merged
kc1212
reviewed
Jul 9, 2019
kc1212
reviewed
Jul 9, 2019
kc1212
reviewed
Jul 10, 2019
kc1212
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous tests only unit-tested the catchup and downloadDB methods. This test
runs it in a more production-like environment with transactions being processed
as the node catches up. A couple of problems got fixed:
Depends on dedis/onet#559
Closes #1980