Fixed html.gfi to avoid same gml id for all features #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket 452
Merge deegree master into latlon master
Merge deegree master into latlon master
Merging deegree master into latlon master
Merging new Version
…same GML ID for different features
lgoltz
force-pushed
the
duplicateIdsWithDefaultHtmlGfi-6802
branch
from
f668622 to
99cc3f4
Compare
|
Remark: the example url contains another issue: contains output of org.deegree.gml.reference.FeatureReference.toString() |
tfr42
removed
needs rebase
stephanr
requested changes
Nov 9, 2022
stephanr
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the HTML output of a GFI response contains the same GML ID for each feature.
Example: https://geoportal.saarland.de/gdi-sl/inspirewms_Verwaltungseinheiten_ALKIS?SERVICE=WMS&VERSION=1.3.0&REQUEST=GetFeatureInfo&BBOX=302444.6399650537641719,5356659.78744656965136528,388315.51130642730277032,5586443.87835079990327358&CRS=EPSG:25832&WIDTH=324&HEIGHT=867&LAYERS=AU.AdministrativeUnit&STYLES=&FORMAT=image/png&QUERY_LAYERS=AU.AdministrativeUnit&INFO_FORMAT=text/html&I=152&J=412&FEATURE_COUNT=10
GML: https://geoportal.saarland.de/gdi-sl/inspirewms_Verwaltungseinheiten_ALKIS?SERVICE=WMS&VERSION=1.3.0&REQUEST=GetFeatureInfo&BBOX=302444.6399650537641719,5356659.78744656965136528,388315.51130642730277032,5586443.87835079990327358&CRS=EPSG:25832&WIDTH=324&HEIGHT=867&LAYERS=AU.AdministrativeUnit&STYLES=&FORMAT=image/png&QUERY_LAYERS=AU.AdministrativeUnit&INFO_FORMAT=text/xml&I=152&J=412&FEATURE_COUNT=10
This PR fixed the html.gfi to ensures the correct GML ID per feature.