Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed html.gfi to avoid same gml id for all features #1090

Merged
merged 36 commits into from
Nov 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
430b472
Merge pull request #1 from occamlabs/ticket-452
Dec 14, 2012
93e2c0e
adapted pom to latlon distribution and scm
wilden Dec 21, 2012
70b463c
Merge remote-tracking branch 'deegree3/master'
wilden Jan 8, 2013
30deedc
Merge branch 'master' of https://github.com/deegree/deegree3
wilden Jan 8, 2013
5d9b109
Merge remote-tracking branch 'deegree3/master'
wilden Feb 13, 2013
73a45b0
merged deegree 3 master
wilden Feb 13, 2013
a545b52
Merged deegree3/master into lat-lon/master
Feb 26, 2013
f058238
Update coveragestores.rst
Mar 19, 2013
d1ba29f
Merged deegree/master into lat-lon/master
Mar 20, 2013
c626a7b
merged deegree 3 master
wilden Mar 25, 2013
634248c
Merge pull request #23 from deegree/master
wilden Apr 17, 2013
534765e
Merge pull request #27 from deegree/master
wilden Apr 30, 2013
9ebafd2
Merge pull request #33 from deegree/master
wilden May 21, 2013
673955d
Merge branch 'master' of https://github.com/deegree/deegree3
wilden Jun 13, 2013
d3cf53c
adapted latlon config
wilden Jun 13, 2013
404edff
Merge pull request #35 from deegree/master
wilden Jun 14, 2013
00277b2
Merge remote branch 'upstream/master'
latlon-team Jun 17, 2013
5874dfe
Merge remote-tracking branch 'deegree/master'
lgoltz Sep 12, 2019
99cc3f4
#6802 - added TemplateFeatureInfoSerializerTest, fixed output of the …
lgoltz Sep 17, 2020
377910a
fixed integration tests
lgoltz Feb 2, 2021
064c0c0
fixed integration test
lgoltz Feb 3, 2021
52c596c
Merge remote-tracking branch 'deegree/master'
lgoltz Jun 28, 2021
714e9ba
Merge commit '5b6812a47e9daac228d98c2aa98998cd4f8b9995' into HEAD
latlon-team Jul 2, 2021
9dab3a4
Merge commit 'fc4252d80898f4aaf7a7ef36117aad1a08ba04dc' into HEAD
latlon-team Aug 12, 2021
e6f3a48
Merge branch 'master' into duplicateIdsWithDefaultHtmlGfi-6802
lgoltz Aug 16, 2021
1401ef5
Merge branch 'deegree:master' into master
tfr42 Dec 7, 2021
9fb8bf6
Merge remote-tracking branch 'deegree/master' into duplicateIdsWithDe…
lgoltz Jan 10, 2022
00d181f
Merge branch 'deegree:master' into master
tfr42 Jan 22, 2022
8a3877a
Merge branch 'deegree:master' into master
tfr42 Feb 15, 2022
a076bb0
Merge branch 'deegree:master' into master
tfr42 Feb 22, 2022
7090d6b
Merge commit '9b6a71f0f48b013ec2f2e9cf24b222d07e19df17' into HEAD
latlon-team May 12, 2022
508dba9
Merge commit '7c07944ac6034b303a627b2e037295bf8746eb4b' into HEAD
latlon-team May 13, 2022
a0b3849
Merge commit '821fa175f2df373bab6776634583465b0adf610e' into HEAD
latlon-team May 14, 2022
4496a0f
Merge remote-tracking branch 'origin/master' into duplicateIdsWithDef…
lgoltz Nov 21, 2022
df50206
Merge remote-tracking branch 'deegree/main' into duplicateIdsWithDefa…
lgoltz Nov 22, 2022
2eddaf0
#6802 - removed unused dependency
lgoltz Nov 22, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions deegree-core/deegree-core-featureinfo/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
</dependency>
</dependencies>

</project>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,19 +77,18 @@ if(! this.<?name>_switchfunction){
th(row, "Field").style.cssText = headerStyle
th(row, "Value").style.cssText = headerStyle
for(var i in <?name>){
row = tr(table)
td(row, 'GML ID').style.cssText = headerStyle
td(row, '<?gmlid>').style.cssText = headerStyle
<?name>[i](table)
}
}

<?name> = []
}

<?name>[<?name>.length] = function (table) {
var odd = true
var row
row = tr(table)
td(row, 'GML ID').style.cssText = headerStyle
td(row, '<?gmlid>').style.cssText = headerStyle
<?property *:properties>
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
package org.deegree.featureinfo.serializing;

import org.deegree.feature.FeatureCollection;
import org.deegree.featureinfo.FeatureInfoContext;
import org.deegree.featureinfo.FeatureInfoParams;
import org.deegree.gml.GMLInputFactory;
import org.deegree.gml.GMLStreamReader;
import org.deegree.gml.GMLVersion;
import org.junit.Test;

import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.OutputStream;
import java.net.URL;
import java.util.HashMap;
import java.util.Map;

import static org.hamcrest.CoreMatchers.endsWith;
import static org.hamcrest.CoreMatchers.startsWith;
import static org.junit.Assert.assertThat;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

/**
* @author <a href="mailto:goltz@lat-lon.de">Lyn Goltz </a>
*/
public class TemplateFeatureInfoSerializerTest {

@Test
public void testSerialize_DefautHtmlGfi_ShouldReturnHtml()
throws Exception {
ByteArrayOutputStream bos = new ByteArrayOutputStream();
TemplateFeatureInfoSerializer serializer = new TemplateFeatureInfoSerializer();
FeatureInfoParams params = createParams();
FeatureInfoContext context = mockContext( bos );
serializer.serialize( params, context );

String html = bos.toString().trim();
assertThat( html, startsWith( "<html>" ) );
assertThat( html, endsWith( "</html>" ) );
}

private FeatureInfoParams createParams()
throws Exception {
URL resource = TemplateFeatureInfoSerializer.class.getResource( "featurecollection.gml" );
GMLStreamReader gmlStreamReader = GMLInputFactory.createGMLStreamReader( GMLVersion.GML_32,
resource );
Map<String, String> nsBindings = new HashMap<>();
FeatureCollection col = gmlStreamReader.readFeatureCollection();
return new FeatureInfoParams( nsBindings, col, "text/html", true, null, null, null );
}

private FeatureInfoContext mockContext( OutputStream os )
throws IOException {
FeatureInfoContext mock = mock( FeatureInfoContext.class );
when( mock.getOutputStream() ).thenReturn( os );
return mock;
}
}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<JDBCConnection xmlns="http://www.deegree.org/jdbc" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" configVersion="3.0.0" xsi:schemaLocation="http://www.deegree.org/jdbc http://schemas.deegree.org/jdbc/3.0.0/jdbc.xsd">
<Url>jdbc:postgresql://localhost:5432/deegree3-cite-csw</Url>
<User>postgres</User>
<Password>postgres</Password>
</JDBCConnection>
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<JDBCConnection xmlns="http://www.deegree.org/jdbc" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" configVersion="3.0.0" xsi:schemaLocation="http://www.deegree.org/jdbc http://schemas.deegree.org/jdbc/3.0.0/jdbc.xsd">
<Url>jdbc:postgresql://localhost:5432/deegree3-cite-csw</Url>
<User>postgres</User>
<Password>postgres</Password>
</JDBCConnection>
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,18 @@
th(row, "Field").style.cssText = headerStyle
th(row, "Value").style.cssText = headerStyle
for(var i in DominantVegetation){
row = tr(table)
td(row, 'GML ID').style.cssText = headerStyle
td(row, 'DOMINANTVEGETATION_329').style.cssText = headerStyle
DominantVegetation[i](table)
}
}

DominantVegetation = []
}

DominantVegetation[DominantVegetation.length] = function (table) {
var odd = true
var row
row = tr(table)
td(row, 'GML ID').style.cssText = headerStyle
td(row, 'DOMINANTVEGETATION_329').style.cssText = headerStyle

row = tr(table)
td(row, 'objectid').style.cssText = odd ? oddStyle : evenStyle
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,18 @@
th(row, "Field").style.cssText = headerStyle
th(row, "Value").style.cssText = headerStyle
for(var i in DominantVegetation){
row = tr(table)
td(row, 'GML ID').style.cssText = headerStyle
td(row, 'DOMINANTVEGETATION_329').style.cssText = headerStyle
DominantVegetation[i](table)
}
}

DominantVegetation = []
}

DominantVegetation[DominantVegetation.length] = function (table) {
var odd = true
var row
row = tr(table)
td(row, 'GML ID').style.cssText = headerStyle
td(row, 'DOMINANTVEGETATION_329').style.cssText = headerStyle

row = tr(table)
td(row, 'objectid').style.cssText = odd ? oddStyle : evenStyle
Expand Down