Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of geometries in deegree #1192

Merged
merged 1 commit into from
May 13, 2022
Merged

Fix rendering of geometries in deegree #1192

merged 1 commit into from
May 13, 2022

Conversation

dstenger
Copy link
Contributor

This PR makes miterLimit configurable.
When the configured factor is exceeded portrayal changes from JOIN_MITER to JOIN_BEVEL (see https://docs.oracle.com/javase/tutorial/2d/geometry/strokeandfill.html).

Configuration can be set via JNDI-Env or System-Property.

Example:

<Environment name="deegree.rendering.stroke.miterlimit" value="2.66" 
                       type="java.lang.Float" override="false" 
                       description="deegree Rendering - Miter Limit Factor"/>

or

-Ddeegree.rendering.stroke.miterlimit=2.66

@tfr42 tfr42 added bug error issue and bug (fix) WMS deegree Web Map Service labels Sep 30, 2021
@dstenger dstenger mentioned this pull request Oct 4, 2021
Merged
tfr42
tfr42 reviewed May 12, 2022
View reviewed changes
Copy link
Member

@tfr42 tfr42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on PR #1287 about missing documentation.

tfr42
tfr42 requested changes May 12, 2022
View reviewed changes
Copy link
Member

@tfr42 tfr42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the type Tunable to TunableParameter

This was referenced May 12, 2022
Merged
Merged
@stephanr
Copy link
Member

Rename the type Tunable to TunableParameter

This was done in the follow up PR #1330

@copierrj copierrj merged commit 341ad02 into deegree:master May 13, 2022
@tfr42 tfr42 added this to the 3.4.31 milestone May 13, 2022
@tfr42 tfr42 deleted the bugfix/stroke-miter-limiting-dee-138-196-7692 branch November 17, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfr42 tfr42 tfr42 requested changes

Assignees
No one assigned
Labels
bug error issue and bug (fix) WMS deegree Web Map Service
Projects
None yet
Milestone
3.4.31
Development

Successfully merging this pull request may close these issues.
4 participants
@dstenger @stephanr @tfr42 @copierrj