Fix geometry conversion for simple point geometries on oracle databases #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanr
added
bug
|
Last build (4) ran without issue see https://buildserver.deegree.org/blue/organizations/jenkins/deegree-3.4%2Fpull-request/detail/PR-1287/4/pipeline |
|
I will change the System Property Usage and Documentation introduced in #1192 |
tfr42
reviewed
May 12, 2022
* allow to disable optimized point storage globally
+ switch from System.getProperty to TunableParameter
stephanr
force-pushed
the
bugfix/oracle-dialect-optimized-point-storage
branch
from
d4ab7ac to
b7b0c2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the geometry would have never been stored as an optimized point for a 2D point.
This originates from the check for
ordinates.length > 2 && ordinates.length < 4which only applies to 3D points at the moment.To fix this bug and also to prevent Multipoint (2005/3005) geometries with only a single point to be stored wrongly, the type check was narrowed down to 2D/3D simple point (2001/3001).
It also may or may not be a desired option to never use optimized point storage, so the option to use
-Ddeegree.sqldialect.oracle.optimized_point_storage=falsewas included.