Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade of Servlet API to 3.1 and JSF to 2.2 including Primefaces to v11.0 #1271

Merged
merged 10 commits into from
Sep 21, 2022
Merged

Upgrade of Servlet API to 3.1 and JSF to 2.2 including Primefaces to v11.0 #1271

merged 10 commits into from
Sep 21, 2022

Conversation

tfr42
Copy link
Member

@tfr42 tfr42 commented Jan 24, 2022 •
edited
Loading

Fixes issues #990 and #991 by upgrading to Servlet API 3.1 and JSF 2.2 with Primefaces 8.0,
also removes weblogic.xml deployment descriptor from deegree-webservices webapp.
Also the following changes are included:

tfr42 added 3 commits November 23, 2019 18:01
@tfr42
Fixes deegree#991 Upgrade to Servlet API 3.1.0, JSF 2.2, JSP 2.3, EL …
fe8e4a2 
…3.0, removes outdated deployment descriptor for unsupported weblogic server
@tfr42
deegree#991 upgraded to primefaces 8.0, added JSF listener
61ea927
@tfr42
Merge branch 'master' into feature/upgradeJSF990-991
783d3b8 
# Conflicts:
#	deegree-services/deegree-services-commons/src/main/java/org/deegree/services/controller/utils/HttpResponseBuffer.java
#	deegree-tests/deegree-csw-bkg/src/main/webapp/WEB-INF/web.xml
#	deegree-workspaces/deegree-workspace-csw/src/main/webapp/WEB-INF/web.xml
#	deegree-workspaces/deegree-workspace-wpvs/src/main/webapp/WEB-INF/web.xml
@tfr42 tfr42 added console deegree administration console dependencies Pull requests that update a dependency (library) in progress labels Jan 24, 2022
@tfr42 tfr42 added this to the 3.5 milestone May 15, 2022
@tfr42 tfr42 changed the title Upgrade Servlet API to 3.1 and JSF to 2.2 including Richfaces 8.0 Upgrade Servlet API to 3.1 and JSF to 2.2 including Richfaces 11.0 May 15, 2022
@tfr42 tfr42 added the needs rebase PR is not up to date and needs rebase label May 16, 2022
@tfr42 tfr42 removed the needs rebase PR is not up to date and needs rebase label Jun 3, 2022
@tfr42 tfr42 added ready and removed in progress labels Sep 18, 2022
@tfr42
Copy link
Member Author

tfr42 commented Sep 18, 2022 •
edited
Loading

Note:
Local tests using the Jetty Maven plugin with mvn jetty:run in deegree3/deegree-services/deegree-webservices are failing due to Java Modules violation for JAI library:

java.lang.IllegalAccessError: class it.geosolutions.imageio.stream.input.spi.FileImageInputStreamExtImplSpi (in unnamed module @0x45764297) cannot access class com.sun.imageio.spi.FileImageInputStreamSpi (in module java.desktop) because module java.desktop does not export com.sun.imageio.spi to unnamed module @0x45764297
        at it.geosolutions.imageio.stream.input.spi.FileImageInputStreamExtImplSpi.onRegistration(FileImageInputStreamExtImplSpi.java:116)

Adding the following jvmargs didn't solve the issue:
<jvmArgs>--illegal-access=warn --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.desktop/com.sun.imageio.spi=ALL-UNNAMED --add-exports java.desktop/sun.awt=ALL-UNNAMED --add-exports java.desktop/com.sun.imageio.spi=ALL-UNNAMED --add-exports java.desktop/sun.swing=ALL-UNNAMED --add-opens java.desktop/javax.imageio.spi=ALL-UNNAMED</jvmArgs>

Local tests with Tomcat on docker do not show such errors. Using the following command:
docker run -d --name deegree35 -v ./deegree3/deegree-services/deegree-webservices/target/deegree-webservices-3.5.0-SNAPSHOT.war:/usr/local/tomcat/webapps/deegree-webservices.war -v ~/.deegree:/root/.deegree -p 8080:8080 tomcat:9-jdk11

@tfr42
deegree#991 improved configuration of jetty maven plugin to run deegr…
ad03e8b 
…ee webapp with Java 11 and preventing IllegalAccessErrors due to Java modules
@copierrj copierrj merged commit 1da5eb3 into deegree:main Sep 21, 2022
@tfr42 tfr42 removed the ready label Sep 21, 2022
@tfr42 tfr42 mentioned this pull request Oct 4, 2022
Closed
@tfr42 tfr42 deleted the feature/upgradeJSF990-991 branch October 4, 2022 14:16
This was referenced Oct 4, 2022
Closed
Closed
Closed
@tfr42 tfr42 changed the title Upgrade Servlet API to 3.1 and JSF to 2.2 including Richfaces 11.0 Upgrade of Servlet API to 3.1 and JSF to 2.2 including Richfaces to v11.0 Mar 27, 2023
@tfr42 tfr42 changed the title Upgrade of Servlet API to 3.1 and JSF to 2.2 including Richfaces to v11.0 Upgrade of Servlet API to 3.1 and JSF to 2.2 including Primefaces to v11.0 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
console deegree administration console dependencies Pull requests that update a dependency (library)
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@tfr42 @copierrj