Add support for rectangular (box-styled) halo #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanr
added
enhancement
stephanr
force-pushed
the
enhancement/box-styled-halo-83
branch
from
a171319 to
50dc184
Compare
stephanr
force-pushed
the
enhancement/box-styled-halo-83
branch
from
50dc184 to
31f6a1e
Compare
|
Fixed merge conflict by rebase. |
tfr42
requested changes
Dec 7, 2022
deegree-services/deegree-webservices-handbook/src/main/asciidoc/renderstyles.adoc
Outdated
Show resolved
Hide resolved
re-enabled testTextStyling2 as problis with this test might also be only font related
…rence (test-only)
stephanr
force-pushed
the
enhancement/box-styled-halo-83
branch
from
31f6a1e to
0af25aa
Compare
The font files are now tracked as maven test dependency. |
tfr42
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a (smal) reworked part of the larger PR #1204
It adds the possibility to use rectangular helo effects when rendering text.
This is similar to the way deegree2 rendered halo as boxes.
It also contains an edge-case fix so that when halos are set (<> 0) it will be rendered with at least a size of one pixel.
EDIT:
For the test to work, it was necessary to include and load a font so that the test was run with the same font.
The Fonts distributed with each JDK distribution differ and can as well differ on the platforms (win/mac/linux).
EDIT2:
The previously added Font was replaced with an maven dependency.
The Font is licensed, under "SIL OPEN FONT LICENSE Version 1.1" see also https://search.maven.org/artifact/com.mpobjects.jasperreports.font/jasperreports-fonts-liberation/2.1.2/jar