Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance SLD/SE functions #1204

Closed
wants to merge 22 commits into from
Closed

Enhance SLD/SE functions #1204

wants to merge 22 commits into from

Conversation

dstenger
Copy link
Contributor

@dstenger dstenger commented Oct 4, 2021 •
edited
Loading

This pull request contains multiple SLD/SE enhancements.

This includes:

  • SPI for Graphic/Mark/WellKnownName
  • Optimization of fill
  • Function AchoredSymbol
  • WKTParser2
  • Enhancement of WKTWriter
  • GeoServer symbols ( shape://, extshape://, qgis:// )
  • TTF symbol syntax with GeoServer syntax (ttf://)
  • Symbols basing on WKT syntax (wkt://)
  • SVG path syntax (svgpath://)
  • ogc:Function HatchingDistance

Some tests are not passing and are ignored: https://github.com/lat-lon/deegree3/blob/enhancement/migrations-styling-enhacments-dee-83-7692/deegree-core/deegree-core-geometry/src/test/java/org/deegree/geometry/WKTReader2JTSGeometryTests.java
Those tests should be fixed before merging this pull request.

This PR includes PR #1244 (JTS).

@dstenger dstenger added the enhancement enhancement or improvement label Oct 4, 2021
@dstenger dstenger mentioned this pull request Oct 5, 2021
Closed
@tfr42 tfr42 added the WMS deegree Web Map Service label Oct 25, 2021
@dstenger dstenger added the tests failing unit or Integration tests fail label Dec 15, 2021
@lgoltz lgoltz force-pushed the enhancement/migrations-styling-enhacments-dee-83-7692 branch from 1f34a19 to 2ce8aef Compare January 3, 2022 06:17
@tfr42 tfr42 added the CI failing CI build job fails label Feb 4, 2022
@copierrj
Copy link
Member

The TMC discussed this PR and we would like you to consider breaking it up into smaller pieces (read: separate PRs) that can be merged individually. While this is not absolutely required we would greatly appreciate your effort.

@tfr42 tfr42 added the needs rebase PR is not up to date and needs rebase label May 16, 2022
@tfr42 tfr42 removed the tests failing unit or Integration tests fail label Aug 10, 2022
@tfr42 tfr42 removed needs rebase PR is not up to date and needs rebase CI failing CI build job fails labels Aug 10, 2022
@tfr42 tfr42 changed the title SLD/SE enhancements Enhances SLD/SE functions Sep 21, 2022
@tfr42 tfr42 changed the title Enhances SLD/SE functions Enhance SLD/SE functions Sep 21, 2022
This was referenced Sep 29, 2022
Merged
Merged
@stephanr stephanr mentioned this pull request Oct 10, 2022
Merged
@stephanr stephanr mentioned this pull request Oct 18, 2022
Merged
@stephanr stephanr mentioned this pull request Nov 2, 2022
Closed
@stephanr stephanr mentioned this pull request Nov 9, 2022
Merged
@tfr42 tfr42 added the invalid invalid label Nov 9, 2022
@tfr42
Copy link
Member

tfr42 commented Nov 9, 2022

Relates to #1420, #1418, #1412

@stephanr stephanr mentioned this pull request Nov 11, 2022
Merged
@stephanr
Copy link
Member

These PR can completely replaced with these reworked PRs:

@copierrj copierrj closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement enhancement or improvement invalid invalid WMS deegree Web Map Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dstenger @copierrj @tfr42 @stephanr @lgoltz