Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending the SLD/SE rendering capabilities of Mark for more symbols and better area fill #1410

Merged

Conversation

stephanr
Copy link
Member

@stephanr stephanr commented Oct 10, 2022

This PR is the, reworked, main part of the larger PR #1204 and includes #1420.

The following part are included:

  • a new extension point, which allows implementing custom Graphic/Mark/WellKnownName handlers.
  • (new) test cases which render a feature collection with a style and compare the results to the image
    • bbox is provided by the featurecollection, with and height is taken from the reference image
  • corrections that improve the rendering of symbols for area fills
  • documentation is reduced to the parts included in this pr
  • the implementation for WellKnownName whit the prefixes shape://, extshape://, qgis:// and ttf:// do not include new or changed dependecies and are reworked versions from their geoserver/geotools counterpart (which is also LGPL 2.1 or newer)
  • include a helper function to calculate the size of an mark for simplified hatching
  • as a result of these works the rendering of fill will look a little different
    • a comparison can be previed by looking at commit d0ab83a

@stephanr stephanr added enhancement enhancement or improvement WMS deegree Web Map Service labels Oct 10, 2022
@stephanr stephanr added this to the 3.5 milestone Oct 10, 2022
@stephanr stephanr changed the title Extending the SLD/SE rendering capabilities of' Mark for more symbols and better area fill Extending the SLD/SE rendering capabilities of Mark for more symbols and better area fill Oct 10, 2022
@stephanr stephanr added the needs rebase PR is not up to date and needs rebase label Nov 14, 2022
@stephanr stephanr force-pushed the enhancement/se-sld-styling-imporvements-83-289 branch 2 times, most recently from d0ab83a to 092e1c7 Compare November 17, 2022 08:50
@stephanr stephanr force-pushed the enhancement/se-sld-styling-imporvements-83-289 branch from 092e1c7 to a32de82 Compare November 17, 2022 09:06
@stephanr
Copy link
Member Author

The PR was rebased to the current main, and also the obsolete change of ShapeStroke was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement WMS deegree Web Map Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants