Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make last glyph of font reachable for point rendering #1421

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Make last glyph of font reachable for point rendering #1421

merged 2 commits into from
Dec 14, 2022

Conversation

stephanr
Copy link
Member

@stephanr stephanr commented Nov 9, 2022 •
edited
Loading

Includes/Depends PR #1420

The current implementation had issues and prohibited to use the last glyph index.
For example, the font TestSymbol.ttf has only one glyph at index 3.

image

References:

@stephanr stephanr added bug error issue and bug (fix) WMS deegree Web Map Service labels Nov 9, 2022
@stephanr stephanr added this to the 3.5 milestone Nov 9, 2022
@stephanr stephanr added the needs rebase PR is not up to date and needs rebase label Dec 7, 2022
@stephanr stephanr force-pushed the bugfix/last-font-symbol-unreachable branch from da88327 to 17a9817 Compare December 14, 2022 15:30
@stephanr stephanr removed the needs rebase PR is not up to date and needs rebase label Dec 14, 2022
@copierrj copierrj merged commit a62d0fd into deegree:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfr42 tfr42 tfr42 approved these changes

Assignees
No one assigned
Labels
bug error issue and bug (fix) WMS deegree Web Map Service
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanr @tfr42 @copierrj