tmc meeting minutes 20241009

Meeting Minutes 2024-10-09

(17:00) <stenger>Hi
(17:01) <tfr42>Hi
(17:01) <StephanR>Hi
(17:02) - julianzz98 joined
(17:02) <StephanR>https://meet.google.com/niw-dfkh-dzy
(17:08) - copierrj joined
(17:08) <copierrj>hi
(17:08) <StephanR>Hi
(17:08) <StephanR>https://meet.google.com/niw-dfkh-dzy
(17:11) <tfr42>Let's start with the meeting....
(17:12) <tfr42>First any open tasks from last meeting?
(17:12) <tfr42>https://github.com/deegree/deegree3/wiki/tmc-meeting-minutes-20240925
(17:12) <copierrj>https://github.com/deegree/deegree3/pull/1746
(17:12) <log-bot_>deegree3#1746 Revert "#1718 moving Spring boot BOM into submodule deegree-tools-gml and fixing deps"
(17:12) <log-bot_>deegree3#1746 copierrj wants to merge 1 commits (9 files) from copierrj:revert_spring_bom
(17:12) <log-bot_>deegree3#1746 build error at 2024-09-25 16:22 see https://buildserver.deegree.org/job/pull-request/job/PR-1746/1/display/redirect
(17:12) <copierrj>i propose to close this PR
(17:13) <copierrj>it was only there to test a theory that turned out not to be true
(17:13) <stenger>+1
(17:13) <julianzz98>+1
(17:13) <StephanR>+1
(17:13) <tfr42>+1
(17:13) <copierrj>+1
(17:13) <stenger>Same applies to https://github.com/deegree/deegree3/pull/1747. The reverted commit did not cause the build failure.
(17:13) <log-bot_>deegree3#1747 Revert "Fix config template for MS SQL Server in the deegree web console"
(17:13) <log-bot_>deegree3#1747 dstenger wants to merge 1 commits (2 files) from deegree:revert-1734-fix/mssqlConfig-1733
(17:13) <log-bot_>deegree3#1747 build error at 2024-09-25 16:22 see https://buildserver.deegree.org/job/pull-request/job/PR-1747/1/display/redirect
(17:14) <stenger>+1
(17:14) <copierrj>+1
(17:14) <tfr42>+1
(17:14) <StephanR>+1
(17:15) <tfr42>Any other open task from last meeting?
(17:17) <tfr42>The build seems to be stable again. We can continue with merging PR.
(17:17) <tfr42>Anything else on the agenda for today?
(17:19) <StephanR>Should we lift the limitation in the buildserver to a single build?
(17:25) <tfr42>I would like to propose to keep the limitation of a single build until the next meeting in 14 days to observe how the jobs recover.
(17:25) <copierrj>+1
(17:25) <stenger>+1
(17:25) <StephanR>+1
(17:25) <julianzz98>+1
(17:27) <tfr42>If there is nothing else to discuss today, let's start merging PR
(17:27) <stenger>https://github.com/deegree/deegree3/pull/1749
(17:27) <log-bot_>deegree3#1749 Remove remote layer pointing to external URL from deegree-workspace-utah [CI and build,workspace,tests]
(17:27) <log-bot_>deegree3#1749 dstenger wants to merge 1 commits (2 files) from lat-lon:removeRemoteLayer
(17:27) <log-bot_>deegree3#1749 build success at 2024-10-09 15:15 see https://buildserver.deegree.org/job/pull-request/job/PR-1749/1/display/redirect
(17:29) <copierrj>+1
(17:30) <stenger>+1
(17:30) <StephanR>+1
(17:31) <tfr42>+1
(17:31) <julianzz98>+1
(17:32) <copierrj>merged
(17:32) <tfr42>https://github.com/deegree/deegree3/pull/1748
(17:32) <log-bot_>deegree3#1748 NOT-MERGEABLE Upgraded jetty and soapUI maven plugins to latest bugfix version [CI and build]
(17:32) <log-bot_>deegree3#1748 tfr42 wants to merge 3 commits (3 files) from lat-lon:fix/integrationTest-soapUiPlugin-1740
(17:32) <log-bot_>deegree3#1748 build success at 2024-10-09 12:31 see https://buildserver.deegree.org/job/pull-request/job/PR-1748/1/display/redirect
(17:33) <stenger>+1
(17:33) <StephanR>+1
(17:33) <copierrj>+1
(17:33) <tfr42>+1
(17:33) <julianzz98>+1
(17:34) <copierrj>merged
(17:36) <tfr42>https://github.com/deegree/deegree3/pull/1738
(17:36) <log-bot_>deegree3#1738 Upgraded maven plugins for jaxb,surefire, failsafe and other [enhancement,CI and build]
(17:36) <log-bot_>deegree3#1738 tfr42 wants to merge 1 commits (1 files) from lat-lon:fix/upgradePlugins-3.6-1464
(17:36) <log-bot_>deegree3#1738 build success at 2024-09-11 16:44 see https://buildserver.deegree.org/job/pull-request/job/PR-1738/3/display/redirect
(17:37) <stenger>+1
(17:37) <copierrj>+1
(17:38) <tfr42>+1
(17:39) <StephanR>+1
(17:40) <julianzz98>+1
(17:40) <copierrj>merged
(17:40) <tfr42>Short reminder. The OWAS check is executed automatically on Jenkins:
(17:40) <tfr42>https://buildserver.deegree.org/view/All/job/owasp-check/
(17:41) <tfr42>https://buildserver.deegree.org/view/All/job/owasp-check/lastCompletedBuild/dependency-check-findings/
(17:44) - copierrj quit (Quit: Client closed)
(17:45) - copierrj joined
(17:51) <stenger>https://github.com/deegree/deegree3/pull/1745
(17:51) <log-bot_>deegree3#1745 Fixed value of nilReason (3.6) [bug]
(17:51) <log-bot_>deegree3#1745 lgoltz wants to merge 1 commits (1 files) from lat-lon:fix/nilReason-199-10003-3.6
(17:51) <log-bot_>deegree3#1745 build success at 2024-10-09 15:36 see https://buildserver.deegree.org/job/pull-request/job/PR-1745/2/display/redirect
(17:53) <stenger>+1
(17:53) <copierrj>+1
(17:53) <StephanR>+1
(17:53) <julianzz98>+1
(17:54) <stenger>Vote also includes https://github.com/deegree/deegree3/pull/1744.
(17:54) <log-bot_>deegree3#1744 Fixed value of nilReason (3.5) [bug]
(17:54) <log-bot_>deegree3#1744 lgoltz wants to merge 1 commits (1 files) from lat-lon:fix/nilReason-199-10003
(17:54) <log-bot_>deegree3#1744 build success at 2024-10-09 15:26 see https://buildserver.deegree.org/job/pull-request/job/PR-1744/2/display/redirect
(17:54) <tfr42>+1
(17:54) <tfr42>for both
(17:54) <copierrj>both PRs are merged
(17:57) <julianzz98>Error performing query by operator filter: ORA-00942: table or view does not exist
(17:59) <tfr42>This error is occuring while testing PR #1729
(17:59) <tfr42>https://github.com/deegree/deegree3/pull/1730
(17:59) <tfr42>(3.5)
(17:59) <tfr42>with
(17:59) <tfr42>https://github.com/deegree/deegree3/pull/1732
(17:59) <tfr42>(3.6)
(17:59) <log-bot_>deegree3#1730 Enhance bbox requests without geometry property to consider all geometry properties (3.5) [enhancement]
(17:59) <log-bot_>deegree3#1730 lgoltz wants to merge 1 commits (13 files) from lat-lon:feature/multipleGeomProperties-9885-32
(17:59) <log-bot_>deegree3#1730 build success at 2024-08-28 18:27 see https://buildserver.deegree.org/job/pull-request/job/PR-1730/2/display/redirect
(17:59) <log-bot_>deegree3#1732 Enhance bbox requests without geometry property to consider all geometry properties (3.6) [enhancement]
(17:59) <log-bot_>deegree3#1732 lgoltz wants to merge 2 commits (18 files) from lat-lon:feature/multipleGeomProperties-9885-32-3.6
(18:00) <log-bot_>deegree3#1732 build success at 2024-09-11 17:09 see https://buildserver.deegree.org/job/pull-request/job/PR-1732/4/display/redirect
(18:01) <tfr42>+1
(18:22) <tfr42>There was a long discussion about this PR and we considered to postpone the decision to the next meeting.
(18:24) - stenger quit (Ping timeout: 256 seconds)
(18:26) <copierrj>suggested response: The TMC discussed this PR and we have a few concerns:
(18:26) <copierrj>This PR changes the behavior of deegree in a non-obvious (= to the user) way and we're not sure if that's appropriate  (especially in case of the 3.5 backport) without proper documentation or even making the new behavior opt-in.
(18:26) <copierrj>We also discussed the use of ST_Union in the PostGIS dialect and we are concert that this might result in unexpected performance regressions. One way of dealing with this would be swapping out ST_Union for ST_Collect or rewrite the query by rewriting it to generate a subselect for every single column.
(18:28) - julianzz98 quit (Quit: Client closed)
(18:30) <copierrj>another sentence: Another thing that came up during the discussion was what happens when someone is mixing different coordinate systems.
(18:33) - julianzz98 joined
(18:37) <julianzz98>Have to leave, see you in two weeks!
(18:37) - julianzz98 quit (Client Quit)
(18:39) <copierrj>We also discussed the use of ST_Union in the PostGIS dialect and we are very concerned that the proposed solution results in unexpected performance regressions. Calculating ST_Union can be very expensive on large complex geometries. There are many ways to preventing the use of this (potentially) expensive union, such as using ST_Collect instead,
(18:39) <copierrj>rewrite the query generator to compute extents for every column first and aggregate them later, etc.
(18:41) <StephanR> Another thing that came up during the discussion was what happens when someone is mixing different coordinate systems and or geometry columns that can contain null values.
(18:46) <tfr42>Next TMC meeting in two weeks?
(18:47) <tfr42>2024-10-23 1700-1800
(18:47) <copierrj>+1
(18:47) <tfr42>+1
(18:47) <StephanR>+1
(18:47) <tfr42>Perfect, Thank you... talk to you soon
(18:48) <copierrj>bye
(18:48) <tfr42>bye
(18:48) <StephanR>bye