Consolidate test setup/teardown #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
force-pushed
the
1549-test-cleanup
branch
from
d939be8
to
f54df71
Compare
rcaudy
reviewed
Nov 19, 2021
DB/benchmark/io/deephaven/benchmark/db/TestSortIncrementalPerformance.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/v2/utils/AppendOnlyArrayBackedMutableTable.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/v2/utils/KeyedArrayBackedMutableTable.java
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/v2/utils/KeyedArrayBackedMutableTable.java
Show resolved
Hide resolved
DB/src/test/java/io/deephaven/util/calendar/StaticCalendarMethodsTest.java
Show resolved
Hide resolved
.../barrage/src/test/java/io/deephaven/extensions/barrage/chunk/BarrageColumnRoundTripTest.java
Show resolved
Hide resolved
.../barrage/src/test/java/io/deephaven/extensions/barrage/chunk/BarrageColumnRoundTripTest.java
Outdated
Show resolved
Hide resolved
|
One more fix that needs to be added that got lost: the various ChunkInputStreamGenerator impls need to stop closing the stream they are given, i'll add that patch and test it again. |
niloc132
force-pushed
the
1549-test-cleanup
branch
from
f54df71
to
a9c0b2f
Compare
...rage/src/main/java/io/deephaven/extensions/barrage/chunk/ShortChunkInputStreamGenerator.java
Show resolved
Hide resolved
niloc132
force-pushed
the
1549-test-cleanup
branch
from
a9c0b2f
to
8e7c92b
Compare
nbauernfeind
approved these changes
Nov 23, 2021
rcaudy
approved these changes
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch consolidates various setup/teardown code into LiveTableTestCase for JUnit 3 tests, and DbCleanup for JUnit4 tests, and adds the DbCleanup test rule to other tests that were currently missing it. Those tests that were previously missing it often had incomplete cleanup, which has mostly been removed through this change.
Fixes #1549