Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate test setup/teardown #1581

Merged
merged 11 commits into from
Nov 24, 2021
Merged

Consolidate test setup/teardown #1581

merged 11 commits into from
Nov 24, 2021

Commits on Nov 23, 2021

  1. First draft to clean up query scope in currently failing tests

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    ff65a6e View commit details
    Browse the repository at this point in the history

  2. hack and slash to ensure tests that use query scope clean it up

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    049b0a3 View commit details
    Browse the repository at this point in the history

  3. Correctly dispose of a chunk

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    0d6e5c2 View commit details
    Browse the repository at this point in the history

  4. Clean up another psuedo-rule

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    19a071f View commit details
    Browse the repository at this point in the history

  5. Rearrange test rules

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    b7c8f40 View commit details
    Browse the repository at this point in the history

  6. cleanup

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    066e5c8 View commit details
    Browse the repository at this point in the history

  7. import cleanup

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    735b716 View commit details
    Browse the repository at this point in the history

  8. make fields accessible

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    e1dcf10 View commit details
    Browse the repository at this point in the history

  9. Clean up leaked chunks/etc

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    55c65bd View commit details
    Browse the repository at this point in the history

  10. Review cleanup

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    95154b8 View commit details
    Browse the repository at this point in the history

  11. Drainable.drainTo must not close the outputstream it gets

    @niloc132
    niloc132 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    8e7c92b View commit details
    Browse the repository at this point in the history