Add python wrappers and tests for new update_by operators
#3731
Conversation
lbooker42
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
py/server/deephaven/updateby.py
Outdated
| @@ -164,6 +171,211 @@ def ema_time_decay(ts_col: str, time_scale: Union[int, str], cols: Union[str, Li | |||
| raise DHError(e, "failed to create a time-decay EMA UpdateByOperation.") from e | |||
|
|
|||
|
|
|||
| def ems_tick_decay(time_scale_ticks: int, cols: Union[str, List[str]], | |||
There was a problem hiding this comment.
These new methods suffer from the same problem as the ticket I have reported twice. The timescalee should not be int. It should be float.
I wasn't able to find the other ticket to link to. Maybe it was fixed?
There was a problem hiding this comment.
This is being addressed in #3745, to merge after this.
| return UpdateByOperation(j_updateby_op=_JUpdateByOperation.RollingWAvg(ts_col, rev_time, fwd_time, weight_col, *cols)) | ||
| except Exception as e: | ||
| raise DHError(e, "failed to create a rolling weighted average (time) UpdateByOperation.") from e |
There was a problem hiding this comment.
Did the new EMA std and such not make this cut?
There was a problem hiding this comment.
EM Std is not going to make the EOM release. There are some complexities in the operator that need managed before it can merge.
table-api/src/main/java/io/deephaven/api/updateby/spec/EmMinMaxSpec.java
Show resolved
Hide resolved
|
Added a commit that removes the |
… option, improved test suite, fixed an interface bug.
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/2531 |
Operators wrapped:
When merged, will close #3721