Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python wrappers and tests for new update_by operators #3731

Merged
merged 11 commits into from
Apr 28, 2023
Merged

Add python wrappers and tests for new update_by operators #3731

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c4dfb25
Initial commit of RollingStd
lbooker42 Apr 12, 2023
f15c45c
RollingStd operator passing all test cases.
lbooker42 Apr 12, 2023
cc02471
Merge with main.
lbooker42 Apr 21, 2023
25ed102
WIP, still need to add RollingWAvg
lbooker42 Apr 21, 2023
7aee5e1
Merged with main.
lbooker42 Apr 24, 2023
2ece8b8
Tests written for all new operators.
lbooker42 Apr 24, 2023
7bdb6e5
Refactored python tests to use setUpClass & tearDownClass.
lbooker42 Apr 24, 2023
5a5c4a6
Addressed PR comments.
lbooker42 Apr 25, 2023
39369d3
Spotless applied.
lbooker42 Apr 25, 2023
147bc1f
Renamed em python operators to remove _decay suffix.
lbooker42 Apr 26, 2023
dddc71e
Modified DeltaControl default to NULL_DOMINATES, added ZERO_DOMINATES…
lbooker42 Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions java-client/session/src/main/java/io/deephaven/client/impl/UpdateByBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,19 +233,19 @@ public UpdateByColumn.UpdateBySpec visit(RollingProductSpec rs) {
.build();
}

// TODO: add this correctly to `table.proto` (DHC #3392)
// TODO: add this correctly to `table.proto` (DHC #3666)
@Override
public UpdateByColumn.UpdateBySpec visit(RollingCountSpec spec) {
return null;
}

// TODO: add this correctly to `table.proto` (DHC #3392)
// TODO: add this correctly to `table.proto` (DHC #3666)
@Override
public UpdateByColumn.UpdateBySpec visit(RollingStdSpec spec) {
return null;
}

// TODO: add this correctly to `table.proto` (DHC #3392)
// TODO: add this correctly to `table.proto` (DHC #3666)
@Override
public UpdateByColumn.UpdateBySpec visit(RollingWAvgSpec spec) {
return null;
Expand Down
Loading