feat: Extract Codec & friends from Util into separate modules #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
added
core
devinrsmith
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Note, you'll want to merge the latest main and update how annotations is depended on since #5724 merged.
Also, looks like you need to apply spotless and fix some failing tests.
codec/base/src/main/java/io/deephaven/util/codec/ObjectCodec.java
Outdated
Show resolved
Hide resolved
codec/base/src/main/java/io/deephaven/util/codec/ObjectDecoder.java
Outdated
Show resolved
Hide resolved
devinrsmith
reviewed
Jul 9, 2024
devinrsmith
reviewed
Jul 9, 2024
devinrsmith
reviewed
Jul 9, 2024
rcaudy
reviewed
Jul 9, 2024
codec/builtin/src/test/java/io/deephaven/util/codec/LocalTimeCodecTest.java
Outdated
Show resolved
Hide resolved
codec/builtin/src/test/java/io/deephaven/util/codec/ZonedDateTimeCodecTest.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Jul 10, 2024
This reverts commit 6b3d1fd.
rcaudy
approved these changes
Jul 12, 2024
devinrsmith
approved these changes
Jul 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5726 by removing ObjectCodec and ObjectDecoder, their implementations, as well as CodecCache and it's exception from the Util module and into their own separate packages, codec-base, codec-builtin and codec-cache.