feat: Extract Codec & friends from Util into separate modules #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ven#5727) This fixes deephaven#5726 by removing ObjectCodec and ObjectDecoder, their implementations, as well as CodecCache and it's exception from the Util module and into their own separate packages, codec-base, codec-builtin and codec-cache. (cherry picked from commit 4fdad15)
devinrsmith
changed the title
rcaudy
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5726 by removing ObjectCodec and ObjectDecoder, their implementations, as well as CodecCache and it's exception from the Util module and into their own separate packages, codec-base, codec-builtin and codec-cache.
(cherry picked from commit 4fdad15)