Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DH UI doesn't seem to react to IDE number format changes #435

Closed
kzk2000 opened this issue Apr 24, 2024 · 1 comment · Fixed by deephaven/web-client-ui#1995
Closed

DH UI doesn't seem to react to IDE number format changes #435

kzk2000 opened this issue Apr 24, 2024 · 1 comment · Fixed by deephaven/web-client-ui#1995
Assignees
@mattrunyon
Labels
bug Something isn't working

Comments

@kzk2000
Copy link

kzk2000 commented Apr 24, 2024

@mofojed These settings don't seem to work on DH UI dashboards:

image

tested on edge version:
image
@kzk2000 kzk2000 added bug Something isn't working triage labels Apr 24, 2024
@mofojed mofojed transferred this issue from deephaven/deephaven-core Apr 24, 2024
@mattrunyon
Copy link
Collaborator

When fixing this, check embed-widget as well. I think it just uses default formatters, so it wouldn't get any user settings from the browser

@mofojed mofojed removed the triage label Apr 29, 2024
@mattrunyon mattrunyon mentioned this issue May 7, 2024
Merged
mattrunyon added a commit to deephaven/web-client-ui that referenced this issue May 9, 2024
@mattrunyon
feat: Make grid widget respect global formatter settings (#1995)
d1fba8f 
Fixes deephaven/deephaven-plugins#435

Does not fix the issue in embed-widget. I think that should be a
separate ticket. I'll keep
#1964 open for tracking
that if that seems fine

Tested by creating a dh.ui component that included a table and then
changed the formatter settings. Tried global column formats too (the
formats for specifically named columns)

Looks like ui.table already loads these settings, so this will fix for
normal tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrunyon mattrunyon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Make grid widget respect global formatter settings mattrunyon/web-client-ui
3 participants
@mofojed @kzk2000 @mattrunyon