-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed widget should load workspace settings #1964
Comments
The selector does work without a workspace, but we don't expose it as a possible external dependency. So the easiest fix for now is to bump We'll want to add support for reading user set formatting to embed-grid though in the future |
mattrunyon
changed the title
Embed widget needs to support
Embed widget should load workspace settings
May 9, 2024
getSettings
redux selector
mattrunyon
added a commit
that referenced
this issue
May 9, 2024
Fixes deephaven/deephaven-plugins#435 Does not fix the issue in embed-widget. I think that should be a separate ticket. I'll keep #1964 open for tracking that if that seems fine Tested by creating a dh.ui component that included a table and then changed the formatter settings. Tried global column formats too (the formats for specifically named columns) Looks like ui.table already loads these settings, so this will fix for normal tables.
mattrunyon
added a commit
that referenced
this issue
Jun 12, 2024
Fixes #1964. Also removed a bunch of unnecessary code in `AppInit` where we were using the redux `connect` API with a functional component instead of just using the redux hooks Note that even though this moves a bunch of files to `app-utils`, I don't consider it breaking since they are being moved out of `code-studio`. They wouldn't be consumed by anything else since `code-studio` is published as a bundle. Due to local storage requiring a port match, this can only be tested w/ the local server in 2 steps (this should be fine in prod since the app and embed-widget run on the same port there). 1. Start the dev server and go to the app 2. Run some code to create a table. 3. Change user formatting settings (e.g. show timezones and have a timestamp column) 4. Stop the dev server. 5. Run `PORT=4000 npm run start:embed-widget`. This will let us access the saved workspace from the app 6. Go to `localhost:4000/?name=<your-variable-name>` 7. The formatting settings should be applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some deephaven ui components need formatter settings from the Redux store (e.g. Picker).
As-is, the following query crashes in embed widget:
The text was updated successfully, but these errors were encountered: