Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui.dialog render test #952

Closed
dgodinez-dh opened this issue Oct 23, 2024 · 3 comments · Fixed by #1031
Closed

ui.dialog render test #952

dgodinez-dh opened this issue Oct 23, 2024 · 3 comments · Fixed by #1031
Labels
enhancement New feature or request
Milestone
November 2024

Comments

@dgodinez-dh
Copy link
Contributor

There is a bug in the web-client-ui spectrum theme that is causing the dialog underlay to render incorrectly. It is fixed here:
deephaven/web-client-ui#2267
We need to wait for a new version of Core before adding dialog the the render tests otherwise they will start failing with the new version.

Other notes:

  • dialogs should not be in render_all as they will cover other components
  • they should be defaulted open
  • there are 5 types of dialogs
@dgodinez-dh dgodinez-dh added enhancement New feature or request triage labels Oct 23, 2024
@dgodinez-dh dgodinez-dh mentioned this issue Oct 23, 2024
Merged
@mofojed mofojed removed the triage label Oct 29, 2024
@mofojed mofojed added this to the November 2024 milestone Oct 29, 2024
@mofojed
Copy link
Member

mofojed commented Oct 29, 2024

@dgodinez-dh the latest docker image should now have web version 0.97.0 so this should be doable now.

@dgodinez-dh
Copy link
Contributor Author

@mofojed Last Friday, there was an issue with the overlay color being wrong. I think we need to fix that color before adding the render. @dsmmcken Do you know what the color should be?

@dgodinez-dh
Copy link
Contributor Author

Fyi, I created a new issue for this deephaven/web-client-ui#2276

dgodinez-dh added a commit that referenced this issue Nov 1, 2024
@dgodinez-dh @bmingles
@margaretkennedy @jnumainville
feat: UI Dialog and DialogTrigger Components (#953)
0fbae91 
closes #933
closes #863

Note that there is a bug in the spectrum theme that causes the underlay
to render as transparent. It is fixed here:
deephaven/web-client-ui#2267
The underlay may render incorrectly depending on your version of
`web-client-ui`
Because of this bug, we are waiting for a new version before adding a
render test for dialog. See
#952

---------

Co-authored-by: Brian Ingles <github@emeraldwalk.com>
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
Co-authored-by: Joe <josephnumainville@deephaven.io>
@dgodinez-dh dgodinez-dh mentioned this issue Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

test: Add render tests for dialog dgodinez-dh/deephaven-plugins
2 participants
@mofojed @dgodinez-dh