Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Overlay Color in Theme #2276

Closed
dgodinez-dh opened this issue Oct 31, 2024 · 0 comments · Fixed by #2277
Closed

Fix Overlay Color in Theme #2276

dgodinez-dh opened this issue Oct 31, 2024 · 0 comments · Fixed by #2277
Labels
bug Something isn't working triage Issue requires triage

Comments

@dgodinez-dh
Copy link
Contributor

When demoing ui.dialog, we saw that the modal underlay color was incorrect. The color needs to be fixed in the theme. Possibly for both the dark and light theme (was using dark during the demo). Need a color from @dsmmcken
Relates to #2266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: --dh-color-overlay-modal-bg theme background color to be black not gray deephaven/web-client-ui
1 participant
@dgodinez-dh