Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick filter font doesn't match in Chrome #1472

Closed
mofojed opened this issue Aug 30, 2023 · 0 comments · Fixed by #1475
Closed

Quick filter font doesn't match in Chrome #1472

mofojed opened this issue Aug 30, 2023 · 0 comments · Fixed by #1475
Assignees
Labels
bug Something isn't working

Comments

@mofojed
Copy link
Member

mofojed commented Aug 30, 2023

Description

The font in the text input field when editing a quick filter does not match the font/text drawn on the canvas, and it looks like the input shifts. This seems to only be reproducible on Chrome; Firefox looks correct (see attachments).

Steps to reproduce

  1. On a table, open the Quick Filter and enter the number '37'
  2. Click off the quick filter, and then click into the quick filter

Expected results
2. Text should line up exactly whether the field is in focus or not.

Actual results
2. Text shifts and the spacing is different. See videos:

Additional details and attachments
On Chrome you can see the text shift quite a bit, the spacing is different:
font-issue-chrome

On Firefox you can see the font is the same (though it does look like it shifts up/down about a half pixel):
font-issue-firefox

Versions
Engine Version: 0.28.0
Web UI Version: 0.46.0
Java Version: 11.0.15
Barrage Version: 0.6.0
Chrome Version: 114.0.5735.198 (arm64)
Firefox Version: 116.0.3

Note: This is also preventing Playwright from being updated to 1.37.1, as this issue is present there.

@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Aug 30, 2023
@mofojed mofojed removed the triage Issue requires triage label Aug 30, 2023
@mofojed mofojed added this to the September 2023 milestone Aug 30, 2023
@dsmmcken dsmmcken linked a pull request Sep 1, 2023 that will close this issue
dsmmcken added a commit that referenced this issue Sep 7, 2023
resolves: #1472 

looks like tnum wasn't being inherited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants