-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quick filter focus text doesn't match canvas text #1475
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
=======================================
Coverage 45.74% 45.74%
=======================================
Files 516 516
Lines 35095 35095
Branches 8785 8785
=======================================
Hits 16055 16055
Misses 18989 18989
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That massively mis-aligns it for me in chrome/win the opposite direction. |
I am guessing we are running up against platform limitations. I adjusted so it's right in chrome/firefox on windows, but I don't think we can get it perfect against the matrix of OS and browsers. Does it look reasonable to you on linux or is it way off still? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect for me on Ubuntu in both Firefox and Chrome. Mac it shifts up/down by a pixel or two, but fonts look the same.
I think just rebase off the latest and update snapshots then this is good to go. Thanks!
2de2418
to
fad405b
Compare
resolves: #1472
looks like tnum wasn't being inherited.