Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to open a context menu with a custom context menu already open does not work #1525

Closed
mattrunyon opened this issue Sep 18, 2023 · 0 comments · Fixed by #1526 or deephaven/deephaven-core#4559
Closed

Trying to open a context menu with a custom context menu already open does not work #1525

mattrunyon opened this issue Sep 18, 2023 · 0 comments · Fixed by #1526 or deephaven/deephaven-core#4559
Assignees
@mattrunyon
Labels
bug Something isn't working
Milestone
September 2023

Comments

@mattrunyon
Copy link
Collaborator

Description

If you have a custom context menu already open (like on a table) and right click on something else that should create a custom context menu (like another table), the browser default context menu is opened instead.

Steps to reproduce

  1. Open a table
  2. Right click in the table
  3. Custom context menu opens
  4. Right click somewhere else in the table

Expected results

  1. Custom context menu opens

Actual results

  1. Browser default context menu opens

Versions

  • Web UI Version: 0.49.0
  • OS: PopOS 22.04 (Ubuntu-based)
  • Browser: Chromium 117
@mattrunyon mattrunyon added bug Something isn't working triage Issue requires triage labels Sep 18, 2023
@mattrunyon mattrunyon mentioned this issue Sep 19, 2023
Merged
@vbabich vbabich removed the triage Issue requires triage label Sep 19, 2023
@vbabich vbabich added this to the September 2023 milestone Sep 19, 2023
mattrunyon added a commit that referenced this issue Sep 20, 2023
@mattrunyon
fix: Right clicking with a custom context menu open should open anoth…
bd08e1f 
…er context menu (#1526)

Fixes #1525
@mofojed mofojed mentioned this issue Sep 27, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Sep 27, 2023
@github-actions @deephaven-internal
Update web version 0.49.1 (#4559)
c076285 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.49.1

### Bug Fixes

* Copy did not work from embedded iframes ([#1528](deephaven/web-client-ui#1528)) ([3549a33](deephaven/web-client-ui@3549a33)), closes [#1527](deephaven/web-client-ui#1527)
* Dehydration of class components ([#1535](deephaven/web-client-ui#1535)) ([3e834de](deephaven/web-client-ui@3e834de)), closes [#1534](deephaven/web-client-ui#1534)
* inconsistent drag for webkit ([#1518](deephaven/web-client-ui#1518)) ([cd5408c](deephaven/web-client-ui@cd5408c)), closes [#1360](deephaven/web-client-ui#1360)
* Render tables partitioned by non-string columns ([#1533](deephaven/web-client-ui#1533)) ([585b2ff](deephaven/web-client-ui@585b2ff)), closes [#1441](deephaven/web-client-ui#1441)
* Right clicking with a custom context menu open should open another context menu ([#1526](deephaven/web-client-ui#1526)) ([bd08e1f](deephaven/web-client-ui@bd08e1f)), closes [#1525](deephaven/web-client-ui#1525)

# [0.49.0](deephaven/web-client-ui@v0.48.0...v0.49.0) (2023-09-15)


### Bug Fixes

* Plugin peer dependencies do not get versions from lerna ([#1517](deephaven/web-client-ui#1517)) ([322f6ff](deephaven/web-client-ui@322f6ff))
* Table overflow button has lower priority than grid tokens ([#1510](deephaven/web-client-ui#1510)) ([32e6d20](deephaven/web-client-ui@32e6d20)), closes [#1480](deephaven/web-client-ui#1480)


### Code Refactoring

* Improve table saver to always use the correct service worker ([#1515](deephaven/web-client-ui#1515)) ([2488e52](deephaven/web-client-ui@2488e52)), closes [#766](deephaven/web-client-ui#766)


### Features

* Update go to row panel's row number with cursorRow ([#1508](deephaven/web-client-ui#1508)) ([23ab5cc](deephaven/web-client-ui@23ab5cc)), closes [#1406](deephaven/web-client-ui#1406)


### BREAKING CHANGES

* `TableSaver` now expects the service worker to send it
a complete URL for download instead of just a file name. DHE will need
to adjust its `serviceWorker.js` to incorporate the same changes from
this PR.


Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrunyon mattrunyon

Labels
bug Something isn't working
Projects
None yet
Milestone
September 2023
2 participants
@vbabich @mattrunyon