Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-14657 Disconnect handling increase debounce timeout #1347

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Jun 2, 2023

DH-14657

Increases the timeout to 1s. Immediately shows the disconnect icon on the user settings icon when disconnect happens and changes the tooltip (although it will be extremely difficult for the user to trigger that tooltip since the modal will block access to it 1 second later)

Here's how to test w/ ngrok (I couldn't switch between wired and wireless on my PC b/c I need to fix some wifi drivers apparently)

ngrok http 10000
VITE_CORE_API_URL=https://ngrok.link/jsapi npm start

Then open localhost:4000 in firefox and enable work offline from the File menu

@mattrunyon mattrunyon requested a review from mofojed June 2, 2023 20:54
@mattrunyon mattrunyon self-assigned this Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #1347 (c69a915) into main (a4677eb) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
- Coverage   45.95%   45.95%   -0.01%     
==========================================
  Files         493      494       +1     
  Lines       34414    34422       +8     
  Branches     8582     8587       +5     
==========================================
+ Hits        15814    15817       +3     
- Misses      18549    18554       +5     
  Partials       51       51              
Flag Coverage Δ
unit 45.95% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/code-studio/src/main/AppMainContainer.tsx 35.01% <50.00%> (+0.42%) ⬆️

... and 4 files with indirect coverage changes

@mofojed mofojed merged commit 66bdad8 into deephaven:main Jun 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
@mattrunyon mattrunyon deleted the mattrunyon_dh-14657 branch June 23, 2024 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants