Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DH-14657 Disconnect handling increase debounce timeout #1347

Merged
merged 2 commits into from
Jun 2, 2023
Merged

fix: DH-14657 Disconnect handling increase debounce timeout #1347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54ecd1d
Increase delay to 1s and show disconnect icon on settings gear
mattrunyon Jun 2, 2023
c69a915
Add tooltip
mattrunyon Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions packages/code-studio/src/main/AppMainContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ import {
dhShapes,
dhPanels,
vsDebugDisconnect,
dhSquareFilled,
} from '@deephaven/icons';
import dh from '@deephaven/jsapi-shim';
import type {
Expand Down Expand Up @@ -888,12 +889,32 @@ export class AppMainContainer extends Component<
})}
onClick={this.handleSettingsMenuShow}
icon={
<FontAwesomeIcon
icon={vsGear}
transform="grow-3 right-1 down-1"
/>
<span className="fa-layers">
<FontAwesomeIcon
icon={vsGear}
transform="grow-3 right-1 down-1"
/>
{isDisconnected && !isAuthFailed && (
<>
<FontAwesomeIcon
icon={dhSquareFilled}
color={ThemeExport.background}
transform="grow-2 right-8 down-8.5 rotate-45"
/>
<FontAwesomeIcon
icon={vsDebugDisconnect}
color={ThemeExport.danger}
transform="shrink-5 right-6 down-6"
/>
</>
)}
</span>
}
tooltip={
isDisconnected && !isAuthFailed
? 'Server disconnected'
: 'User Settings'
}
tooltip="User Settings"
/>
</div>
</div>
Expand Down Expand Up @@ -954,7 +975,7 @@ export class AppMainContainer extends Component<
/>
<DebouncedModal
isOpen={isDisconnected && !isAuthFailed}
debounceMs={250}
debounceMs={1000}
>
<InfoModal
icon={vsDebugDisconnect}
Expand Down