Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: figure_title and chart_title were not mapped up correctly #1676

Merged
merged 4 commits into from
Dec 19, 2023
Merged

fix: figure_title and chart_title were not mapped up correctly #1676

merged 4 commits into from
Dec 19, 2023

Commits on Dec 18, 2023

  1. fix: Show figure_title when set 

    - We currently were showing the first charts title as the figure title
    @mofojed
    mofojed committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    bb42c86 View commit details
    Browse the repository at this point in the history

  2. fix: Chart titles not appearing over subplots 

    - Needed to add annotations for it
- Fixes deephaven#1675
    @mofojed
    mofojed committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    997f668 View commit details
    Browse the repository at this point in the history

  3. Move it up a little bit

    @mofojed
    mofojed committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    fea30df View commit details
    Browse the repository at this point in the history

  4. Clean up from review comments 

    - Fallback to chart title if there is only one chart and the figure title is not set
- Use `yshift` property to position the text correctly regardless of size of plot
    @mofojed
    mofojed committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9ee6592 View commit details
    Browse the repository at this point in the history