Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to delete selected rows in some input tables #1678

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 8, 2023

- Erroneously assumed that the key columns were the first columns in the table
- Removed unused delete function from `IrisGridTableModelTemplate`
  - It should only be implemented for regular JsTables as JsTreeTables do not have input tables
  - Was duplicated code
- Fixes deephaven#1677
- Tested using the code in the ticket
@mofojed mofojed requested a review from vbabich December 8, 2023 14:45
@mofojed mofojed self-assigned this Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (1b06675) 46.63% compared to head (0e443fb) 46.68%.

Files Patch % Lines
packages/iris-grid/src/IrisGridTableModel.ts 0.00% 7 Missing ⚠️
...ckages/iris-grid/src/IrisGridTableModelTemplate.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
+ Coverage   46.63%   46.68%   +0.05%     
==========================================
  Files         604      604              
  Lines       36753    36711      -42     
  Branches     9211     9206       -5     
==========================================
  Hits        17139    17139              
+ Misses      19562    19520      -42     
  Partials       52       52              
Flag Coverage Δ
unit 46.68% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 1e71550 into deephaven:main Dec 8, 2023
5 checks passed
@mofojed mofojed deleted the input-table-fix branch December 8, 2023 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete rows in input tables when key columns are not the first columns
2 participants