Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete rows in input tables when key columns are not the first columns #1677

Closed
mofojed opened this issue Dec 8, 2023 · 0 comments · Fixed by #1678 or deephaven/deephaven-core#4930
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Dec 8, 2023

Description

If you specify an input table where the key columns are not the first columns in the table, you cannot delete rows.

Steps to reproduce

  1. Execute the following snippet:
from deephaven import empty_table, input_table

_source1 = empty_table(5).update(["Strings=`A` + i", "Integers=i"])
_source2 = empty_table(5).update(["Integers=i", "Strings=`A` + i"])

result1 = input_table(init_table=_source1, key_cols="Strings")
result2 = input_table(init_table=_source1, key_cols="Integers")
result3 = input_table(init_table=_source2, key_cols="Strings")
result4 = input_table(init_table=_source2, key_cols="Integers")
  1. In each resultN table, right-click a row and select "Delete Selected Rows"

Expected results
2. Should be able to delete a row in each table

Actual results
2. Cannot delete a row in result2 and result3 (when the key columns are not the first column). Error message in console:

Unable to delete ranges Array(1)0: GridRange {startColumn: 1, startRow: 1, endColumn: 1, endRow: 1}length: 1[[Prototype]]: Array(0) Error: java.lang.NumberFormatException: For input string: "A1"
    at NumberFormatException.createError (dh-core.js:1218:10)
    at NumberFormatException.initializeBackingError (dh-core.js:1238:46)
    at NumberFormatException.Throwable_0 (dh-core.js:1183:8)
    at NumberFormatException.Exception_1 (dh-core.js:1262:18)
    at NumberFormatException.RuntimeException_1 (dh-core.js:1275:18)
    at NumberFormatException.IllegalArgumentException_0 (dh-core.js:1800:25)
    at new NumberFormatException (dh-core.js:37874:33)
    at Object.__parseAndValidateDouble (dh-core.js:1553:16)
    at Object.ofNumber (dh-core.js:20928:27)
    at TableUtils.makeFilterRawValue (TableUtils.ts:1789:27)
    at IrisGridTableModel.ts:296:45
    at Array.map (<anonymous>)
    at IrisGridTableModel.delete (IrisGridTableModel.ts:291:26)

Additional details and attachments
image

Versions

Engine Version: 0.31.0-SNAPSHOT
Web UI Version: 0.55.0
Java Version: 11.0.21
Barrage Version: 0.6.0

@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Dec 8, 2023
@mofojed mofojed self-assigned this Dec 8, 2023
@mofojed mofojed removed the triage Issue requires triage label Dec 8, 2023
@mofojed mofojed added this to the November 2023 milestone Dec 8, 2023
mofojed added a commit to mofojed/web-client-ui that referenced this issue Dec 8, 2023
- Erroneously assumed that the key columns were the first columns in the table
- Removed unused delete function from `IrisGridTableModelTemplate`
  - It should only be implemented for regular JsTables as JsTreeTables do not have input tables
  - Was duplicated code
- Fixes deephaven#1677
- Tested using the code in the ticket
mofojed added a commit that referenced this issue Dec 8, 2023
- Erroneously assumed that the key columns were the first columns in the
table
- Removed unused delete function from `IrisGridTableModelTemplate`
- It should only be implemented for regular JsTables as JsTreeTables do
not have input tables
  - Was duplicated code
- Fixes #1677
- Tested using the code in the ticket
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Dec 11, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.56.0

# [0.56.0](deephaven/web-client-ui@v0.55.0...v0.56.0) (2023-12-11)


### Bug Fixes

* add right margin to <Button kind='inline'/> using icons ([#1664](deephaven/web-client-ui#1664)) ([fd8a6c6](deephaven/web-client-ui@fd8a6c6))
* adjust filter bar colour ([#1666](deephaven/web-client-ui#1666)) ([4c0200e](deephaven/web-client-ui@4c0200e))
* convert organize columns component to purecomponent ([#1653](deephaven/web-client-ui#1653)) ([8ddc114](deephaven/web-client-ui@8ddc114)), closes [#1650](deephaven/web-client-ui#1650)
* Default to `Skip` operation instead of `Sum` operation ([#1648](deephaven/web-client-ui#1648)) ([6083173](deephaven/web-client-ui@6083173)), closes [#1355](deephaven/web-client-ui#1355) [#1355](deephaven/web-client-ui#1355)
* Fix button snapshots ([#1655](deephaven/web-client-ui#1655)) ([c0cc966](deephaven/web-client-ui@c0cc966))
* popper blur in styleguide ([#1672](deephaven/web-client-ui#1672)) ([6fa2204](deephaven/web-client-ui@6fa2204))
* Unable to delete selected rows in some input tables ([#1678](deephaven/web-client-ui#1678)) ([1e71550](deephaven/web-client-ui@1e71550)), closes [#1677](deephaven/web-client-ui#1677)


### Features

* Add embed-widget ([#1668](deephaven/web-client-ui#1668)) ([1b06675](deephaven/web-client-ui@1b06675)), closes [#1629](deephaven/web-client-ui#1629)
* forward and back button for organize column search ([#1641](deephaven/web-client-ui#1641)) ([89f2be5](deephaven/web-client-ui@89f2be5)), closes [#1529](deephaven/web-client-ui#1529)
* Tables that have names starting with underscore do not auto-launch from console ([#1656](deephaven/web-client-ui#1656)) ([21131fe](deephaven/web-client-ui@21131fe)), closes [#1549](deephaven/web-client-ui#1549) [#1410](deephaven/web-client-ui#1410)
* theme fontawesome icon size wrapped in spectrum icons ([#1658](deephaven/web-client-ui#1658)) ([2aa8cef](deephaven/web-client-ui@2aa8cef))
* Theme Selector ([#1661](deephaven/web-client-ui#1661)) ([5e2be64](deephaven/web-client-ui@5e2be64)), closes [#1660](deephaven/web-client-ui#1660)
* Theming - Bootstrap ([#1603](deephaven/web-client-ui#1603)) ([88bcae0](deephaven/web-client-ui@88bcae0))
* Theming - Inline svgs ([#1651](deephaven/web-client-ui#1651)) ([1e40d3e](deephaven/web-client-ui@1e40d3e))
* View cell contents in context menu ([#1657](deephaven/web-client-ui#1657)) ([90b7517](deephaven/web-client-ui@90b7517)), closes [#1605](deephaven/web-client-ui#1605)


### BREAKING CHANGES

* Bootstrap color variables are now predominantly hsl based. SCSS will need to be updated accordingly. Theme providers are needed to load themes.
* Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked.

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant