Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV upload doesn't work in release candidate #1677

Closed
kosak opened this issue Dec 9, 2021 · 1 comment · Fixed by #1682
Closed

CSV upload doesn't work in release candidate #1677

kosak opened this issue Dec 9, 2021 · 1 comment · Fixed by #1682
Assignees
@niloc132
Labels
bug Something isn't working release blocker A bug/behavior that puts is below the "good enough" threshold to release.
Milestone
Dec 2021

Comments

@kosak
Copy link
Contributor

kosak commented Dec 9, 2021

I install Deephaven per the instructions (except with VERSION = edge)

Following the instructions in Deephaven -> How-to -> User interface -> Upload and download table data, I

Upload Table from File
Select deephaven-deployment/python/data/examples/DeNiro/csv/deniro.csv
Press Upload

Error on console: java.lang.IllegalArgumentException: No support for handling data of type string

Also the g is weirdly cut off so it looks like strin.
@kosak kosak added bug Something isn't working triage labels Dec 9, 2021
@rcaudy rcaudy added release blocker A bug/behavior that puts is below the "good enough" threshold to release. triage and removed triage labels Dec 9, 2021
@rcaudy rcaudy added this to the Dec 2021 milestone Dec 9, 2021
@niloc132
Copy link
Member

niloc132 commented Dec 9, 2021

Broken by #1565, we need to have some other aliases for types, the UI expects to refer to a java.lang.String column as just "string".

niloc132 added a commit to niloc132/deephaven-core that referenced this issue Dec 10, 2021
@niloc132
JS API should support generic aliases for types the UI will use
b2facf4 
This fixes some CSV column types broken by deephaven#1565.

Fixes deephaven#1677
@niloc132 niloc132 mentioned this issue Dec 10, 2021
Merged
niloc132 added a commit that referenced this issue Dec 13, 2021
@niloc132
JS API should support generic aliases for types the UI will use (#1682)
2ba8a6d 
This fixes some CSV column types broken by #1565.

Fixes #1677
mofojed pushed a commit that referenced this issue Dec 11, 2023
@github-actions @deephaven-internal
Update web version 0.56.0 (#4930)
c29aaf8 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.56.0

# [0.56.0](deephaven/web-client-ui@v0.55.0...v0.56.0) (2023-12-11)


### Bug Fixes

* add right margin to <Button kind='inline'/> using icons ([#1664](deephaven/web-client-ui#1664)) ([fd8a6c6](deephaven/web-client-ui@fd8a6c6))
* adjust filter bar colour ([#1666](deephaven/web-client-ui#1666)) ([4c0200e](deephaven/web-client-ui@4c0200e))
* convert organize columns component to purecomponent ([#1653](deephaven/web-client-ui#1653)) ([8ddc114](deephaven/web-client-ui@8ddc114)), closes [#1650](deephaven/web-client-ui#1650)
* Default to `Skip` operation instead of `Sum` operation ([#1648](deephaven/web-client-ui#1648)) ([6083173](deephaven/web-client-ui@6083173)), closes [#1355](deephaven/web-client-ui#1355) [#1355](deephaven/web-client-ui#1355)
* Fix button snapshots ([#1655](deephaven/web-client-ui#1655)) ([c0cc966](deephaven/web-client-ui@c0cc966))
* popper blur in styleguide ([#1672](deephaven/web-client-ui#1672)) ([6fa2204](deephaven/web-client-ui@6fa2204))
* Unable to delete selected rows in some input tables ([#1678](deephaven/web-client-ui#1678)) ([1e71550](deephaven/web-client-ui@1e71550)), closes [#1677](deephaven/web-client-ui#1677)


### Features

* Add embed-widget ([#1668](deephaven/web-client-ui#1668)) ([1b06675](deephaven/web-client-ui@1b06675)), closes [#1629](deephaven/web-client-ui#1629)
* forward and back button for organize column search ([#1641](deephaven/web-client-ui#1641)) ([89f2be5](deephaven/web-client-ui@89f2be5)), closes [#1529](deephaven/web-client-ui#1529)
* Tables that have names starting with underscore do not auto-launch from console ([#1656](deephaven/web-client-ui#1656)) ([21131fe](deephaven/web-client-ui@21131fe)), closes [#1549](deephaven/web-client-ui#1549) [#1410](deephaven/web-client-ui#1410)
* theme fontawesome icon size wrapped in spectrum icons ([#1658](deephaven/web-client-ui#1658)) ([2aa8cef](deephaven/web-client-ui@2aa8cef))
* Theme Selector ([#1661](deephaven/web-client-ui#1661)) ([5e2be64](deephaven/web-client-ui@5e2be64)), closes [#1660](deephaven/web-client-ui#1660)
* Theming - Bootstrap ([#1603](deephaven/web-client-ui#1603)) ([88bcae0](deephaven/web-client-ui@88bcae0))
* Theming - Inline svgs ([#1651](deephaven/web-client-ui#1651)) ([1e40d3e](deephaven/web-client-ui@1e40d3e))
* View cell contents in context menu ([#1657](deephaven/web-client-ui#1657)) ([90b7517](deephaven/web-client-ui@90b7517)), closes [#1605](deephaven/web-client-ui#1605)


### BREAKING CHANGES

* Bootstrap color variables are now predominantly hsl based. SCSS will need to be updated accordingly. Theme providers are needed to load themes.
* Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked.

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

Labels
bug Something isn't working release blocker A bug/behavior that puts is below the "good enough" threshold to release.
Projects
None yet
Milestone
Dec 2021
Development

Successfully merging a pull request may close this issue.

JS API should support generic aliases for types the UI will use niloc132/deephaven-core
3 participants
@niloc132 @kosak @rcaudy