Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"View full contents" for text cells should be available from context menu #1605

Closed
rbasralian opened this issue Oct 31, 2023 · 1 comment · Fixed by #1657 or deephaven/deephaven-core#4930
Closed

"View full contents" for text cells should be available from context menu #1605

rbasralian opened this issue Oct 31, 2023 · 1 comment · Fixed by #1657 or deephaven/deephaven-core#4930
Assignees
@dsmmcken
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
November 2023

Comments

@rbasralian
Copy link

When a String column is too narrow to display its full contents, there is a button that lets you open a dialog that shows the full contents:

image

This is helpful because the "Cell Contents" dialog lets you select and copy just a portion of the text:

image

However, if the column happens to already be wide enough to display the full cell contents, there is no way to get to the "Cell Contents" dialog, since the button disappears:

image

And it is not available in the context menu:

image
@rbasralian rbasralian added enhancement New feature or request triage Issue requires triage labels Oct 31, 2023
@vbabich vbabich added the good first issue Good for newcomers label Oct 31, 2023
@vbabich
Copy link
Collaborator

vbabich commented Oct 31, 2023

Label as "View Cell Contents". Place as own menu group at the end of list. Only show on string columns.

@vbabich vbabich removed the triage Issue requires triage label Oct 31, 2023
@vbabich vbabich added this to the November 2023 milestone Oct 31, 2023
dsmmcken added a commit that referenced this issue Nov 24, 2023
@dsmmcken
feat: View cell contents in context menu
203ef8d 
Resolves #1605
@dsmmcken dsmmcken mentioned this issue Nov 24, 2023
Merged
@dsmmcken dsmmcken self-assigned this Nov 24, 2023
dsmmcken added a commit that referenced this issue Nov 27, 2023
@dsmmcken
feat: View cell contents in context menu (#1657)
90b7517 
Resolves #1605
@mofojed mofojed mentioned this issue Dec 11, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Dec 11, 2023
@github-actions @deephaven-internal
Update web version 0.56.0 (#4930)
c29aaf8 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.56.0

# [0.56.0](deephaven/web-client-ui@v0.55.0...v0.56.0) (2023-12-11)


### Bug Fixes

* add right margin to <Button kind='inline'/> using icons ([#1664](deephaven/web-client-ui#1664)) ([fd8a6c6](deephaven/web-client-ui@fd8a6c6))
* adjust filter bar colour ([#1666](deephaven/web-client-ui#1666)) ([4c0200e](deephaven/web-client-ui@4c0200e))
* convert organize columns component to purecomponent ([#1653](deephaven/web-client-ui#1653)) ([8ddc114](deephaven/web-client-ui@8ddc114)), closes [#1650](deephaven/web-client-ui#1650)
* Default to `Skip` operation instead of `Sum` operation ([#1648](deephaven/web-client-ui#1648)) ([6083173](deephaven/web-client-ui@6083173)), closes [#1355](deephaven/web-client-ui#1355) [#1355](deephaven/web-client-ui#1355)
* Fix button snapshots ([#1655](deephaven/web-client-ui#1655)) ([c0cc966](deephaven/web-client-ui@c0cc966))
* popper blur in styleguide ([#1672](deephaven/web-client-ui#1672)) ([6fa2204](deephaven/web-client-ui@6fa2204))
* Unable to delete selected rows in some input tables ([#1678](deephaven/web-client-ui#1678)) ([1e71550](deephaven/web-client-ui@1e71550)), closes [#1677](deephaven/web-client-ui#1677)


### Features

* Add embed-widget ([#1668](deephaven/web-client-ui#1668)) ([1b06675](deephaven/web-client-ui@1b06675)), closes [#1629](deephaven/web-client-ui#1629)
* forward and back button for organize column search ([#1641](deephaven/web-client-ui#1641)) ([89f2be5](deephaven/web-client-ui@89f2be5)), closes [#1529](deephaven/web-client-ui#1529)
* Tables that have names starting with underscore do not auto-launch from console ([#1656](deephaven/web-client-ui#1656)) ([21131fe](deephaven/web-client-ui@21131fe)), closes [#1549](deephaven/web-client-ui#1549) [#1410](deephaven/web-client-ui#1410)
* theme fontawesome icon size wrapped in spectrum icons ([#1658](deephaven/web-client-ui#1658)) ([2aa8cef](deephaven/web-client-ui@2aa8cef))
* Theme Selector ([#1661](deephaven/web-client-ui#1661)) ([5e2be64](deephaven/web-client-ui@5e2be64)), closes [#1660](deephaven/web-client-ui#1660)
* Theming - Bootstrap ([#1603](deephaven/web-client-ui#1603)) ([88bcae0](deephaven/web-client-ui@88bcae0))
* Theming - Inline svgs ([#1651](deephaven/web-client-ui#1651)) ([1e40d3e](deephaven/web-client-ui@1e40d3e))
* View cell contents in context menu ([#1657](deephaven/web-client-ui#1657)) ([90b7517](deephaven/web-client-ui@90b7517)), closes [#1605](deephaven/web-client-ui#1605)


### BREAKING CHANGES

* Bootstrap color variables are now predominantly hsl based. SCSS will need to be updated accordingly. Theme providers are needed to load themes.
* Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked.

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsmmcken dsmmcken

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
November 2023
3 participants
@dsmmcken @vbabich @rbasralian