Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add isInvalid prop to Select component #1883

Merged
merged 3 commits into from
Apr 3, 2024
Merged

fix: Add isInvalid prop to Select component #1883

merged 3 commits into from
Apr 3, 2024

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Mar 20, 2024

FIxes #1882

@vbabich vbabich self-assigned this Mar 20, 2024
@vbabich vbabich enabled auto-merge (squash) March 20, 2024 18:23
@vbabich vbabich requested review from mofojed and dsmmcken March 20, 2024 18:23
dsmmcken
dsmmcken previously requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an example in the styleguide after <Select> showing a <Select isInvalid>

mofojed
mofojed reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just add to styleguide

@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.20%. Comparing base (bfbf7b1) to head (f29ceb8).

Files Patch % Lines
packages/code-studio/src/styleguide/Inputs.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1883      +/-   ##
==========================================
- Coverage   46.20%   46.20%   -0.01%     
==========================================
  Files         641      641              
  Lines       38218    38219       +1     
  Branches     9670     9670              
==========================================
  Hits        17659    17659              
- Misses      20506    20507       +1     
  Partials       53       53
Flag Coverage Δ
unit 46.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbabich vbabich force-pushed the add-is-invalid-prop-to-select branch from 8a25807 to 286d769 Compare March 27, 2024 18:37
@vbabich vbabich force-pushed the add-is-invalid-prop-to-select branch from 286d769 to f29ceb8 Compare March 27, 2024 18:40
@vbabich vbabich requested review from dsmmcken and mofojed March 27, 2024 19:22
mofojed
mofojed approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying we had to update all those snapshots...

@vbabich vbabich dismissed dsmmcken’s stale review April 3, 2024 15:38

Style guide updated.

@vbabich vbabich merged commit 1803f31 into deephaven:main Apr 3, 2024
5 checks passed
@vbabich vbabich deleted the add-is-invalid-prop-to-select branch April 3, 2024 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

@dsmmcken dsmmcken Awaiting requested review from dsmmcken

Assignees

@vbabich vbabich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isInvalid prop is missing in the Select component
3 participants
@vbabich @dsmmcken @mofojed