Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isInvalid prop is missing in the Select component #1882

Closed
vbabich opened this issue Mar 20, 2024 · 0 comments · Fixed by #1883 or deephaven/deephaven-core#5330
Closed

isInvalid prop is missing in the Select component #1882

vbabich opened this issue Mar 20, 2024 · 0 comments · Fixed by #1883 or deephaven/deephaven-core#5330
Assignees
@vbabich
Labels
bug Something isn't working
Milestone
March 2024

Comments

@vbabich
Copy link
Collaborator

vbabich commented Mar 20, 2024

Enterprise uses isInvalid prop on input components to set an invalid state. Most inputs have this prop, except the Select component.

Invalid selects display a warning in the browser console:

Warning: React does not recognize the `isInvalid` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `isinvalid` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
at select
@vbabich vbabich added bug Something isn't working triage Issue requires triage labels Mar 20, 2024
@vbabich vbabich mentioned this issue Mar 20, 2024
Merged
@vbabich vbabich added this to the March 2024 milestone Mar 20, 2024
@vbabich vbabich self-assigned this Mar 20, 2024
@vbabich vbabich removed the triage Issue requires triage label Mar 26, 2024
vbabich added a commit that referenced this issue Apr 3, 2024
@vbabich
fix: Add isInvalid prop to Select component (#1883)
1803f31 
FIxes #1882
@mofojed mofojed mentioned this issue Apr 4, 2024
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Apr 4, 2024
@github-actions @deephaven-internal
Update web version 0.72.0 (#5330)
2d74d77 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.72.0

# [0.72.0](deephaven/web-client-ui@v0.71.0...v0.72.0) (2024-04-04)


### Bug Fixes

* Add isInvalid prop to Select component ([#1883](deephaven/web-client-ui#1883)) ([1803f31](deephaven/web-client-ui@1803f31)), closes [#1882](deephaven/web-client-ui#1882)
* adjust alignment of search input next/previous buttons ([#1917](deephaven/web-client-ui#1917)) ([c7fcd38](deephaven/web-client-ui@c7fcd38))
* Dashboard onLayoutInitialized not firing if config is empty ([#1914](deephaven/web-client-ui#1914)) ([84c648b](deephaven/web-client-ui@84c648b))
* package-lock missing pinned dependency ([#1920](deephaven/web-client-ui#1920)) ([1d9d216](deephaven/web-client-ui@1d9d216))


### Code Refactoring

* Change embed-grid and embed-chart to redirects ([#1873](deephaven/web-client-ui#1873)) ([e17619a](deephaven/web-client-ui@e17619a))


### Features

* Picker - formatter settings ([#1907](deephaven/web-client-ui#1907)) ([f06a141](deephaven/web-client-ui@f06a141)), closes [#1889](deephaven/web-client-ui#1889)
* re-export spectrum useStyleProp util ([#1916](deephaven/web-client-ui#1916)) ([aafa14b](deephaven/web-client-ui@aafa14b))
* wrap spectrum View, Text and Heading to accept custom colors ([#1903](deephaven/web-client-ui#1903)) ([a03fa07](deephaven/web-client-ui@a03fa07))


### BREAKING CHANGES

* `@deephaven/embed-grid` does not handle messages to the
iframe for filtering or sorting the grid any more





Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vbabich vbabich

Labels
bug Something isn't working
Projects
None yet
Milestone
March 2024
1 participant
@vbabich