Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lastBy produces garbage values #1916

Closed
chipkent opened this issue Feb 1, 2022 · 2 comments
Closed

lastBy produces garbage values #1916

chipkent opened this issue Feb 1, 2022 · 2 comments
Assignees
Labels
bug Something isn't working triage

Comments

@chipkent
Copy link
Member

chipkent commented Feb 1, 2022

See the query below. It produces a table of ints and stringsets. When last by is applied, the stringset column starts with garbage values.

The problem is observed in 0.9.0.


from deephaven.TableTools import emptyTable

ArrayStringSet = jpy.get_type("io.deephaven.stringset.ArrayStringSet")

values = ["A", "B", "C"]

def to_string_set() -> ArrayStringSet:
    """ Converts an iterable to a string set. """
    # print("HERE")
    return ArrayStringSet(values)


# t = emptyTable(10).update("SS = (io.deephaven.stringset.StringSet)to_string_set()")
# m = t.getMeta()

import threading
from time import sleep
import deephaven.Types as dht
from deephaven import DynamicTableWriter
from deephaven.conversion_utils import NULL_DOUBLE

dtw = DynamicTableWriter(["A","B"],[dht.int32, dht.stringset])

def populate():
    for i in range(1000):
        dtw.logRow([i, to_string_set()])

thread = threading.Thread(target=populate)
thread.start()

t1 = dtw.getTable()
t2 = t1.lastBy("A")
t3 = t1.naturalJoin(t2,"A", "C=B")
t2m = t2.getMeta()

image
image
image

@chipkent chipkent added bug Something isn't working triage labels Feb 1, 2022
@chipkent
Copy link
Member Author

chipkent commented Feb 1, 2022

Here is a better t2 screenshot.
image

@rcaudy rcaudy assigned niloc132 and rcaudy and unassigned rcaudy Feb 1, 2022
@niloc132
Copy link
Member

niloc132 commented Feb 1, 2022

Can't reproduce at this time, closing for now.

@niloc132 niloc132 closed this as completed Feb 1, 2022
mofojed pushed a commit that referenced this issue Apr 4, 2024
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.72.0

# [0.72.0](deephaven/web-client-ui@v0.71.0...v0.72.0) (2024-04-04)


### Bug Fixes

* Add isInvalid prop to Select component ([#1883](deephaven/web-client-ui#1883)) ([1803f31](deephaven/web-client-ui@1803f31)), closes [#1882](deephaven/web-client-ui#1882)
* adjust alignment of search input next/previous buttons ([#1917](deephaven/web-client-ui#1917)) ([c7fcd38](deephaven/web-client-ui@c7fcd38))
* Dashboard onLayoutInitialized not firing if config is empty ([#1914](deephaven/web-client-ui#1914)) ([84c648b](deephaven/web-client-ui@84c648b))
* package-lock missing pinned dependency ([#1920](deephaven/web-client-ui#1920)) ([1d9d216](deephaven/web-client-ui@1d9d216))


### Code Refactoring

* Change embed-grid and embed-chart to redirects ([#1873](deephaven/web-client-ui#1873)) ([e17619a](deephaven/web-client-ui@e17619a))


### Features

* Picker - formatter settings ([#1907](deephaven/web-client-ui#1907)) ([f06a141](deephaven/web-client-ui@f06a141)), closes [#1889](deephaven/web-client-ui#1889)
* re-export spectrum useStyleProp util ([#1916](deephaven/web-client-ui#1916)) ([aafa14b](deephaven/web-client-ui@aafa14b))
* wrap spectrum View, Text and Heading to accept custom colors ([#1903](deephaven/web-client-ui#1903)) ([a03fa07](deephaven/web-client-ui@a03fa07))


### BREAKING CHANGES

* `@deephaven/embed-grid` does not handle messages to the
iframe for filtering or sorting the grid any more





Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

3 participants