Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golden layout fallback for unregistered components #194

Merged
merged 5 commits into from
Sep 14, 2021

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Sep 10, 2021

Fixes #184

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, just remove the console.log statements and it should be good.

@mofojed mofojed added the enhancement New feature or request label Sep 13, 2021
vbabich and others added 2 commits September 13, 2021 14:44
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
@vbabich vbabich merged commit 1e54245 into deephaven:main Sep 14, 2021
@vbabich vbabich deleted the golden_layout_fallback_component branch September 14, 2021 15:54
@mofojed mofojed mentioned this pull request Sep 24, 2021
mofojed added a commit to mofojed/web-client-ui that referenced this pull request Oct 14, 2021
* `code-studio`, `iris-grid`
  * [deephaven#199](deephaven#199) Remove default formatting rules ([@mofojed](https://github.com/mofojed))

* `code-studio`, `golden-layout`
  * [deephaven#194](deephaven#194) Golden layout fallback for unregistered components ([@vbabich](https://github.com/vbabich))

* `iris-grid`
  * [deephaven#206](deephaven#206) Fix up some issues with input tables ([@mofojed](https://github.com/mofojed))
* `code-studio`, `iris-grid`
  * [deephaven#199](deephaven#199) Remove default formatting rules ([@mofojed](https://github.com/mofojed))

* Other
  * [deephaven#211](deephaven#211) Remove unnecessary uses flag ([@mofojed](https://github.com/mofojed))
  * [deephaven#210](deephaven#210) Add registry-url back, add release action ([@mofojed](https://github.com/mofojed))
  * [deephaven#209](deephaven#209) Fix the registry used when publishing ([@mofojed](https://github.com/mofojed))
  * [deephaven#204](deephaven#204) Update publish actions ([@mofojed](https://github.com/mofojed))
* `golden-layout`
  * [deephaven#198](deephaven#198) Fix package-lock in golden-layout ([@mofojed](https://github.com/mofojed))

- Mike Bender ([@mofojed](https://github.com/mofojed))
- [@vbabich](https://github.com/vbabich)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request web-client-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement fallback for unregistered components in GoldenLayout
2 participants