Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default formatting rules #199

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Sep 16, 2021

- Default formatting rules were legacy from Enterprise days. Remove these rules, as they are unexpected in Community.
- Fixes deephaven#197
- Breaking Change: Formatter no longer has getDefaultFormattingRules
@mofojed mofojed added bug Something isn't working web-client-ui breaking labels Sep 16, 2021
@mofojed mofojed requested a review from vbabich September 16, 2021 18:48
@mofojed mofojed self-assigned this Sep 16, 2021
@mofojed mofojed merged commit 389d582 into deephaven:main Sep 16, 2021
@mofojed mofojed deleted the 197-formatter branch September 16, 2021 19:09
@mofojed mofojed mentioned this pull request Sep 24, 2021
mofojed added a commit to mofojed/web-client-ui that referenced this pull request Oct 14, 2021
* `code-studio`, `iris-grid`
  * [deephaven#199](deephaven#199) Remove default formatting rules ([@mofojed](https://github.com/mofojed))

* `code-studio`, `golden-layout`
  * [deephaven#194](deephaven#194) Golden layout fallback for unregistered components ([@vbabich](https://github.com/vbabich))

* `iris-grid`
  * [deephaven#206](deephaven#206) Fix up some issues with input tables ([@mofojed](https://github.com/mofojed))
* `code-studio`, `iris-grid`
  * [deephaven#199](deephaven#199) Remove default formatting rules ([@mofojed](https://github.com/mofojed))

* Other
  * [deephaven#211](deephaven#211) Remove unnecessary uses flag ([@mofojed](https://github.com/mofojed))
  * [deephaven#210](deephaven#210) Add registry-url back, add release action ([@mofojed](https://github.com/mofojed))
  * [deephaven#209](deephaven#209) Fix the registry used when publishing ([@mofojed](https://github.com/mofojed))
  * [deephaven#204](deephaven#204) Update publish actions ([@mofojed](https://github.com/mofojed))
* `golden-layout`
  * [deephaven#198](deephaven#198) Fix package-lock in golden-layout ([@mofojed](https://github.com/mofojed))

- Mike Bender ([@mofojed](https://github.com/mofojed))
- [@vbabich](https://github.com/vbabich)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Something isn't working web-client-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable non-standard UI presentation by default
2 participants