Skip to content

Conversation

grysgreat
Copy link

and design the parameter json structure and parameter Jsonization code of input_file module.

(The json parameters added this time are all the parameters mentioned in the input file file in /docs/advance/input_files. The recently modified or added parameters are not added to the json class parameters)

What's changed?

  • Add para_json.cpp/h and the corresponding test file, and modify the code in the READ function in input.cpp. The code added by pr this time will not affect the current code logic of abacus.

Linked Issue

Refactor #3104

-- issue #3104

…er, design the parameter json structure and parameter Jsonization code of input_file module.

(The json parameters added this time are all the parameters mentioned in the input file file in /docs/advance/input_files. The recently modified or added parameters are not added to the json class parameters)

-- issue #3104
@pxlxingliang pxlxingliang merged commit 9483bc2 into deepmodeling:develop Dec 5, 2023
dyzheng pushed a commit to dyzheng/abacus-develop that referenced this pull request Dec 8, 2023
@dyzheng dyzheng mentioned this pull request Dec 8, 2023
3 tasks
dyzheng pushed a commit to dyzheng/abacus-develop that referenced this pull request Dec 8, 2023
dyzheng added a commit that referenced this pull request Dec 8, 2023
… parameter (#3228)" (#3319)

This reverts commit 9483bc2.

Co-authored-by: dyzheng <zhengdy@bjaisi.com>
dyzheng added a commit that referenced this pull request Dec 9, 2023
* Revert "Refactor(output-json): Implement the json namespace of abacus parameter (#3228)"

This reverts commit 9483bc2.

* Revert "Revert "Refactor(output-json): Implement the json namespace of abacus parameter (#3228)""

This reverts commit 7a381ea.

---------

Co-authored-by: dyzheng <zhengdy@bjaisi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants