Skip to content

Revert #3228 #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

Revert #3228 #3319

merged 1 commit into from
Dec 8, 2023

Conversation

dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Dec 8, 2023

… parameter (#3228)"

This reverts commit 9483bc2.

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@dyzheng dyzheng requested a review from pxlxingliang December 8, 2023 08:32
@dyzheng dyzheng enabled auto-merge (squash) December 8, 2023 09:14
@dyzheng dyzheng merged commit 69b0b93 into deepmodeling:develop Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pxlxingliang pxlxingliang pxlxingliang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dyzheng @pxlxingliang