- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.5k
 
Closed
Labels
Contributions wanted!Looking for external contributionsLooking for external contributionsP2Medium priority, add to the next sprint if no P1 availableMedium priority, add to the next sprint if no P1 available
Description
Is your feature request related to a problem? Please describe.
I'm trying to minimize the number of components in my RAG retrieval pipeline that rely on running in the threadpool to be async compatible. It looks like that the SentenceWindowRetriever could easily (maybe I'm missing something) support run_async method by relying on the document_store.filter_documents_async method.
Describe the solution you'd like
Add the run_async to SentenceWindowRetriever that relies on document_store.filter_documents_async method.
Describe alternatives you've considered
The most general solution is already implemented in the library itself - run the component in a threadpool. I don't know any other good solutions.
Additional context
- I saw the internal implementation of 
SentenceWindowRetriever.runmethod and I realize that most processing/work is being done inside the component itself, but that doesn't mean that the component should not be fully async friendly. - I did not find any discussion in the previous PRs related to 
SentenceWindowRetrieverthat comment/discuss why therun_asyncis not implemented. - I can work on the PR.
 
Metadata
Metadata
Assignees
Labels
Contributions wanted!Looking for external contributionsLooking for external contributionsP2Medium priority, add to the next sprint if no P1 availableMedium priority, add to the next sprint if no P1 available
Type
Projects
Status
Done