Skip to content

Conversation

@cmnemoi
Copy link
Contributor

@cmnemoi cmnemoi commented Oct 18, 2025

Related Issues

Proposed Changes:

Added async support to SentenceWindowRetriever via a new run_async method that uses filter_documents_async() instead of the sync version. The logic remains identical to the sync implementation.

How did you test it?

Following the codebase convention (similar to haystack-core-integrations/pgvector), I created a separate unit and integration test file which test the same scenarios as for sync run operation.

Checklist

@cmnemoi cmnemoi requested a review from a team as a code owner October 18, 2025 11:57
@cmnemoi cmnemoi requested review from sjrl and removed request for a team October 18, 2025 11:57
@CLAassistant
Copy link

CLAassistant commented Oct 18, 2025

CLA assistant check
All committers have signed the CLA.

@sjrl
Copy link
Contributor

sjrl commented Oct 20, 2025

hey @cmnemoi could you also add a release note for your PR as explained here

@coveralls
Copy link
Collaborator

coveralls commented Oct 20, 2025

Pull Request Test Coverage Report for Build 18679322565

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 92.198%

Files with Coverage Reduction New Missed Lines %
core/pipeline/async_pipeline.py 3 65.88%
components/retrievers/sentence_window_retriever.py 5 94.0%
Totals Coverage Status
Change from base Build 18678235855: -0.002%
Covered Lines: 13459
Relevant Lines: 14598

💛 - Coveralls

@cmnemoi
Copy link
Contributor Author

cmnemoi commented Oct 20, 2025

hey @cmnemoi could you also add a release note for your PR as explained here

@sjrl Done

@vercel
Copy link

vercel bot commented Oct 20, 2025

@cmnemoi is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@sjrl sjrl merged commit 47c3a2b into deepset-ai:main Oct 21, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add run_async method to SentenceWindowRetriever

4 participants