Skip to content

clear redundant timers#4308

Merged
loadams merged 1 commit intodeepspeedai:masterfrom
starkhu:pipe-engine-branch
Sep 14, 2023
Merged

clear redundant timers#4308
loadams merged 1 commit intodeepspeedai:masterfrom
starkhu:pipe-engine-branch

Conversation

@starkhu
Copy link
Contributor

@starkhu starkhu commented Sep 12, 2023

No description provided.

@tjruwase
Copy link
Contributor

@starkhu, this does not seem redundant as it makes it possible for client code to probe timers on other ranks.

@starkhu
Copy link
Contributor Author

starkhu commented Sep 13, 2023

@starkhu, this does not seem redundant as it makes it possible for client code to probe timers on other ranks.

hello, @tjruwase !
i just trying to clean up out-dated events on other ranks. in more details, it is no necessary to save all previous iteration events in the current iteration , otherwise, 'len(self.times('train_batch').event_times )' is gradually increasing on other ranks。

@tjruwase
Copy link
Contributor

@starkhu, I see your point. You are correct. Thanks!

@loadams loadams enabled auto-merge September 14, 2023 17:29
@loadams loadams added this pull request to the merge queue Sep 14, 2023
Merged via the queue into deepspeedai:master with commit e20e4a9 Sep 14, 2023
CurryRice233 added a commit to CurryRice233/DeepSpeed that referenced this pull request Sep 15, 2023
* origin/master: (48 commits)
  Fix autotune to support Triton 2.1  (deepspeedai#4340)
  Fix skipped inference tests (deepspeedai#4336)
  Suppress noise (deepspeedai#4310)
  Fix a bug in the implementation of dequantization for inference (deepspeedai#3433)
  DS-Chat BLOOM: Fix Attention mask (deepspeedai#4338)
  clear redundant timers (deepspeedai#4308)
  Add release version checking (deepspeedai#4328)
  Fix Zero3 contiguous grads, reduce scatter false  accuracy issue (deepspeedai#4321)
  Clean up modeling code (deepspeedai#4320)
  Handle empty parameter groups (deepspeedai#4277)
  Update README.md (deepspeedai#4316)
  README update (deepspeedai#4303)
  Update release and bump patch versioning flow (deepspeedai#4286)
  added a bert-model check for triton (deepspeedai#4266)
  ZeRO-Inference v2 release
  bump to 0.10.4
  Update index.md (deepspeedai#4297)
  fix user args parsing of string with spaces on runner (deepspeedai#4265)
  ZeRO-Inference refresh (deepspeedai#4197)
  AMD Kernel Compatibility Fixes (deepspeedai#3180)
  ...
@starkhu starkhu deleted the pipe-engine-branch branch September 18, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants